NotificationsYou must be signed in to change notification settings
Fork425
Star2k

Commitea14831

committed

Use EXPECT_FALSE instead of EXPECT_EQ(false, X)

This fixes the failures we're finding from the CI builds.

1 parent9e76e5f commitea14831Copy full SHA for ea14831

File tree

1 file changed

-5

lines changed

libs/network/test/http
- request_incremental_parser_test.cpp

1 file changed

-5

lines changed

`‎libs/network/test/http/request_incremental_parser_test.cpp‎`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ TEST(IncrementalRequestParserTest, ParseMethod) {`
`52`	`52`	`p.reset();`
`53`	`53`	`std::tie(parsed_ok, result_range) =`
`54`	`54`	`p.parse_until(request_parser_type::method_done, invalid_http_method);`
`55`		`-EXPECT_EQ(false,parsed_ok);`
	`55`	`+EXPECT_FALSE(parsed_ok);`
`56`	`56`	`parsed.assign(std::begin(result_range),std::end(result_range));`
`57`	`57`	`std::cout <<"PARSED:" << parsed <<" [state:" << p.state() <<"]"`
`58`	`58`	`<< std::endl;`
`@@ -68,7 +68,7 @@ TEST(IncrementalRequestParserTest, ParseURI) {`
`68`	`68`	`std::string valid_http_request ="GET / HTTP/1.1\r\n";`
`69`	`69`	`std::tie(parsed_ok, result_range) =`
`70`	`70`	`p.parse_until(request_parser_type::uri_done, valid_http_request);`
`71`		`-EXPECT_EQ(true,parsed_ok);`
	`71`	`+EXPECT_TRUE(parsed_ok);`
`72`	`72`	`EXPECT_FALSE(boost::empty(result_range));`
`73`	`73`	`std::stringparsed(std::begin(result_range),std::end(result_range));`
`74`	`74`	`std::cout <<"PARSED:" << parsed <<" [state:" << p.state() <<"]"`
`@@ -78,7 +78,7 @@ TEST(IncrementalRequestParserTest, ParseURI) {`
`78`	`78`	`p.reset();`
`79`	`79`	`std::tie(parsed_ok, result_range) =`
`80`	`80`	`p.parse_until(request_parser_type::uri_done, invalid_http_request);`
`81`		`-EXPECT_EQ(false,parsed_ok);`
	`81`	`+EXPECT_FALSE(parsed_ok);`
`82`	`82`	`parsed.assign(std::begin(result_range),std::end(result_range));`
`83`	`83`	`std::cout <<"PARSED:" << parsed <<" [state:" << p.state() <<"]"`
`84`	`84`	`<< std::endl;`
`@@ -104,7 +104,7 @@ TEST(IncrementalRequestParserTest, ParseHTTPVersion) {`
`104`	`104`	`p.reset();`
`105`	`105`	`std::tie(parsed_ok, result_range) =`
`106`	`106`	`p.parse_until(request_parser_type::version_done, invalid_http_request);`
`107`		`-EXPECT_EQ(false,parsed_ok);`
	`107`	`+EXPECT_FALSE(parsed_ok);`
`108`	`108`	`parsed.assign(std::begin(result_range),std::end(result_range));`
`109`	`109`	`std::cout <<"PARSED:" << parsed <<" [state:" << p.state() <<"]"`
`110`	`110`	`<< std::endl;`
`@@ -121,7 +121,7 @@ TEST(IncrementalRequestParserTest, ParseHTTPHeaders) {`
`121`	`121`	`"GET / HTTP/1.1\r\nHost: cpp-netlib.org\r\n\r\n";`
`122`	`122`	`std::tie(parsed_ok, result_range) =`
`123`	`123`	`p.parse_until(request_parser_type::headers_done, valid_http_request);`
`124`		`-EXPECT_EQ(true,parsed_ok);`
	`124`	`+EXPECT_TRUE(parsed_ok);`
`125`	`125`	`EXPECT_FALSE(boost::empty(result_range));`
`126`	`126`	`std::stringparsed(std::begin(result_range),std::end(result_range));`
`127`	`127`	`std::cout <<"PARSED:" << parsed <<" [state:" << p.state() <<"]"`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitea14831

File tree

1 file changed

1 file changed

`‎libs/network/test/http/request_incremental_parser_test.cpp‎`

0 commit comments