Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit38fcd3a

Browse files
committed
Lining up message's get_body
Clang found some hidden virtual functions in message_base. This commitfixes the warnings.
1 parentc20b57e commit38fcd3a

File tree

2 files changed

+198
-198
lines changed

2 files changed

+198
-198
lines changed

‎include/network/message/message.hpp‎

Lines changed: 44 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -15,65 +15,62 @@
1515

1616
namespacenetwork {
1717

18-
structmessage_pimpl;
18+
structmessage_pimpl;
1919

20-
// The common message type.
21-
structmessage : message_base {
22-
// Nested types
23-
typedef boost::iterator_range<
20+
// The common message type.
21+
structmessage : message_base {
22+
// Nested types
23+
typedef boost::iterator_range<
2424
std::multimap<std::string, std::string>::const_iterator>
2525
headers_range;
2626

27-
// Constructors
28-
message();
29-
message(messageconst & other);
27+
// Constructors
28+
message();
29+
message(messageconst & other);
30+
message(message && other) =default;
3031

31-
// Assignment
32-
message &operator=(message other);
32+
// Assignment
33+
message&operator=(messageconst &other);
34+
message&operator=(message &&other);
3335

34-
// Mutators
35-
virtualvoidset_destination(std::stringconst & destination);
36-
virtualvoidset_source(std::stringconst & source);
37-
virtualvoidappend_header(std::stringconst & name,
38-
std::stringconst & value);
39-
virtualvoidremove_headers(std::stringconst & name);
40-
virtualvoidremove_headers();
41-
virtualvoidset_body(std::stringconst & body);
42-
virtualvoidappend_body(std::stringconst & data);
36+
// Mutators
37+
virtualvoidset_destination(std::stringconst & destination);
38+
virtualvoidset_source(std::stringconst & source);
39+
virtualvoidappend_header(std::stringconst & name,
40+
std::stringconst & value);
41+
virtualvoidremove_headers(std::stringconst & name);
42+
virtualvoidremove_headers();
43+
virtualvoidset_body(std::stringconst & body);
44+
virtualvoidappend_body(std::stringconst & data);
4345

44-
// Retrievers
45-
virtualvoidget_destination(std::string & destination)const;
46-
virtualvoidget_source(std::string & source)const;
47-
virtualvoidget_headers(
48-
boost::function<void(std::stringconst &, std::stringconst &)> inserter)const;
49-
virtualvoidget_headers(
50-
std::stringconst & name,
51-
boost::function<void(std::stringconst &, std::stringconst &)> inserter)const;
52-
virtualvoidget_headers(
53-
boost::function<bool(std::stringconst &, std::stringconst &)> predicate,
54-
boost::function<void(std::stringconst &, std::stringconst &)> inserter)const;
55-
virtualvoidget_body(std::string & body)const;
56-
virtualvoidget_body(
57-
boost::function<void(boost::iterator_range<charconst *>)> chunk_reader,
58-
size_t size)const;
46+
// Retrievers
47+
virtualvoidget_destination(std::string & destination)const;
48+
virtualvoidget_source(std::string & source)const;
49+
virtualvoidget_headers(boost::function<void(std::stringconst &, std::stringconst &)> inserter)const;
50+
virtualvoidget_headers(std::stringconst & name,
51+
boost::function<void(std::stringconst &, std::stringconst &)> inserter)const;
52+
virtualvoidget_headers(boost::function<bool(std::stringconst &, std::stringconst &)> predicate,
53+
boost::function<void(std::stringconst &, std::stringconst &)> inserter)const;
54+
virtualvoidget_body(std::string & body)const;
55+
virtualvoidget_body(boost::function<void(std::string::const_iterator,size_t)> chunk_reader, size_t size)const;
5956

60-
voidswap(message & other);
57+
voidswap(message & other);
6158

62-
// Destructor
63-
virtual~message();
64-
private:
65-
message_pimpl * pimpl;
66-
};
59+
// Destructor
60+
virtual~message();
61+
private:
62+
message_pimpl * pimpl;
63+
};
6764

68-
inlinevoidswap(message & left, message & right) {
65+
inlinevoidswap(message & left, message & right) {
6966
left.swap(right);
70-
}
67+
}
7168

72-
template<classDirective>
73-
message_base &operator<< (message_base & msg, Directive directive) {
74-
directive(msg);
75-
return msg;
76-
}
69+
template<classDirective>
70+
message_base &operator<< (message_base & msg, Directive directive) {
71+
directive(msg);
72+
return msg;
73+
}
7774

7875
}// namespace network
7976

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp