Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Better description of 0/1 knapsack#1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spike1236 merged 1 commit intomainfrommhayter-patch-2
Sep 21, 2025
Merged

Better description of 0/1 knapsack#1511

spike1236 merged 1 commit intomainfrommhayter-patch-2
Sep 21, 2025

Conversation

@mhayter
Copy link
Contributor

P.S. Should it be labeled 0/1 Knapsack and not 0-1 Knapsack?

P.S. Should it be labeled 0/1 Knapsack and not 0-1 Knapsack?
@spike1236
Copy link
Member

I also think that it's better to rename it to 0/1 Knapsack

spike1236
spike1236 previously requested changesSep 3, 2025
Copy link
Member

@spike1236spike1236 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

0-1 -> 0/1?

@mhayter
Copy link
ContributorAuthor

Lol I literally left the question as a an open discussion. The title of the actual article uses this convention. I pretty sure that the article consistently uses that convention. We're blocking merging for a change that I did not make?

@adamant-pwn
Copy link
Member

adamant-pwn commentedSep 3, 2025
edited
Loading

Uhh, I feel like the discussion itself is a bit of a bike shedding (as in, it doesn't really matter which way we name it).

Nevertheless, scholarly publications seem to use "0-1 knapsack":1,2,3,4. Unless anyone feel strongly about renaming (and can provide solid reasoning for it), I'd leave the name as is.

@spike1236
Copy link
Member

spike1236 commentedSep 3, 2025
edited
Loading

Sorry, of course I didn't mean to block the PR. I just thought it was valid change to rename 0-1 to 0/1 because I googled the topic and in most cases, it appeared as 0/1 knapsack. So my review was meant to just commit the name change🙌
But, I agree with adamant - there's not much difference in how the topic is named, so both options are valid

@spike1236spike1236 dismissed theirstale reviewSeptember 3, 2025 20:05

Both 0/1 and 0-1 are valid

@mhayter
Copy link
ContributorAuthor

mhayter commentedSep 4, 2025
edited
Loading

It sounds like we're leaving it then and can merge?

spike1236 reacted with thumbs up emoji

@spike1236spike1236 merged commit0e77dbf intomainSep 21, 2025
3 checks passed
@spike1236spike1236 deleted the mhayter-patch-2 branchSeptember 21, 2025 22:37
github-actionsbot added a commit that referenced this pull requestSep 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@spike1236spike1236spike1236 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mhayter@spike1236@adamant-pwn

[8]ページ先頭

©2009-2025 Movatter.jp