Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
Better description of 0/1 knapsack#1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
P.S. Should it be labeled 0/1 Knapsack and not 0-1 Knapsack?
spike1236 commentedSep 1, 2025
I also think that it's better to rename it to 0/1 Knapsack |
spike1236 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
0-1 -> 0/1?
mhayter commentedSep 3, 2025
Lol I literally left the question as a an open discussion. The title of the actual article uses this convention. I pretty sure that the article consistently uses that convention. We're blocking merging for a change that I did not make? |
adamant-pwn commentedSep 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Uhh, I feel like the discussion itself is a bit of a bike shedding (as in, it doesn't really matter which way we name it). Nevertheless, scholarly publications seem to use "0-1 knapsack":1,2,3,4. Unless anyone feel strongly about renaming (and can provide solid reasoning for it), I'd leave the name as is. |
spike1236 commentedSep 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Sorry, of course I didn't mean to block the PR. I just thought it was valid change to rename 0-1 to 0/1 because I googled the topic and in most cases, it appeared as 0/1 knapsack. So my review was meant to just commit the name change🙌 |
mhayter commentedSep 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It sounds like we're leaving it then and can merge? |
0e77dbf intomainUh oh!
There was an error while loading.Please reload this page.
P.S. Should it be labeled 0/1 Knapsack and not 0-1 Knapsack?