Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
feat: add kbd hint#1495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
feat: add kbd hint#1495
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi, thanks for the pull request! It generally looks good, but I'd like to clarify some things first (see comments).
| } | ||
| /* Only show on wider viewports where the inline search is visible */ | ||
| @media (max-width:959px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Where is this value defined? Can we somehow take it from the theme named constants?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
not sure regd. that, can we take 60em instead?
| justify-content: center; | ||
| height:20px; | ||
| padding:06px; | ||
| border-radius:4px; | ||
| border:1px solidvar(--md-default-fg-color--lightest,rgba(0,0,0,.2)); | ||
| background:var(--md-default-bg-color,#fff); | ||
| color:var(--md-default-fg-color,rgba(0,0,0,.87)); | ||
| font:50012px/1var(--md-text-font, system-ui, -apple-system, Segoe UI, Roboto, Ubuntu, Cantarell, Noto Sans, sans-serif); | ||
| opacity:.72; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These seem to mostly repeat things that are already set in.kbd-hint. I'm not that well versed in CSS, is this really necessary? Why do we need them as two independent settings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
they’re separate because one is a DOM element and the other is a pseudo-element positioned inside the input. If we want both contexts covered (inside the field on desktop, next to the icon on mobile/when the field is hidden), we need both targets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What do you mean by next to the icon on mobile / when the field is hidden? For me, when the field is hidden, the hint is hidden as well?
Any update@Venki1402 ? |
Uh oh!
There was an error while loading.Please reload this page.