Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

relocated lis to dp section/add redirect + add relevant links to intro-to_dp#1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
mhayter wants to merge14 commits intocp-algorithms:main
base:main
Choose a base branch
Loading
frommhayter:relocate_lis

Conversation

mhayter
Copy link
Contributor

Did I do this right?

@mhaytermhayter changed the titlerelocated lis to dp section/add redirectrelocated lis to dp section/add redirect + add relevant links to intro-to_dpApr 24, 2025
@mhayter
Copy link
ContributorAuthor

This technically works but probably the links should be edited to be relative as it won't work exactly correctly with absolute links, but I'm dumb and can't figure it out.

Copy link
Member

@adamant-pwnadamant-pwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Let's cleanup the links a bit.

@@ -63,6 +63,7 @@ search:
- Dynamic Programming
- [Introduction to Dynamic Programming](dynamic_programming/intro-to-dp.md)
- [Knapsack Problem](dynamic_programming/knapsack.md)
- [Longest increasing subsequence](dynamic_programming/longest_increasing_subsequence.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unless we very deliberately want it to occur in two sections, we should also remove it from Miscellaneous/Sequences.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm confused on what you mean. Don't we need the redirects?

e_maxx_link: longest_increasing_subseq_log
---

<meta http-equiv="refresh" content="0; url=/dynamic_programming/longest_increasing_subsequence.html">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
<metahttp-equiv="refresh"content="0; url=/dynamic_programming/longest_increasing_subsequence.html">
<metahttp-equiv="refresh"content="0; url=../dynamic_programming/longest_increasing_subsequence.html">

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Does this work? I'd tested my commit and it did work. It seems like it wouldn't now. Is there any easy way to test on the phone lol?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ps I'm a little confused on when we should be directing to .md vs html.

mhayterand others added3 commitsJune 28, 2025 14:51
TyCo-authored-by: Oleksandr Kulkov <adamant.pwn@gmail.com>
TyCo-authored-by: Oleksandr Kulkov <adamant.pwn@gmail.com>
Co-authored-by: Oleksandr Kulkov <adamant.pwn@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@adamant-pwnadamant-pwnadamant-pwn requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mhayter@adamant-pwn

[8]ページ先頭

©2009-2025 Movatter.jp