Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update halfplane-intersection.md#1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Harsh-Mathur-1503 wants to merge3 commits intocp-algorithms:main
base:main
Choose a base branch
Loading
fromHarsh-Mathur-1503:main

Conversation

Harsh-Mathur-1503
Copy link
Contributor

Changes in this commit -

  1. Bounding Box Adjustment: In your initial algorithm (previous code), where you define a static bounding box using Point(inf, inf) and Point(-inf, -inf), you need to replace this with a dynamically calculated bounding box based on the actual input points.
  2. eps and inf Updates: You should update eps and inf in the previous code to values that suit your input size better, handling small floating-point inaccuracies more gracefully.

Changes in this commit - 1. Bounding Box Adjustment: In your initial algorithm (previous code), where you define a static bounding box using Point(inf, inf) and Point(-inf, -inf), you need to replace this with a dynamically calculated bounding box based on the actual input points.2. eps and inf Updates: You should update eps and inf in the previous code to values that suit your input size better, handling small floating-point inaccuracies more gracefully.
@adamant-pwn
Copy link
Member

Hi, thanks for the pull request! Could you please reply to these questions?

  1. Was this PR generated with the help of AI?
  2. Did you check whether your PR actually fixes the issue when run on the example fromHalf-plane intersection #1332?
  3. Why exactly the large bounding box causes a wrong result, and why choosing it dynamically would help?

@mhayter
Copy link
Contributor

Any update@Harsh-Mathur-1503

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Harsh-Mathur-1503@adamant-pwn@mhayter

[8]ページ先頭

©2009-2025 Movatter.jp