Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Rewrite article on Strongly Connected Components, and add graph pictures#1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
adamant-pwn merged 37 commits intocp-algorithms:masterfromel-sambal:master
Jul 16, 2024

Conversation

el-sambal
Copy link
Contributor

This pull request contains a rewrite of the articleStrongly Connected Components and Condensation Graph.

What changed:

  • The article now has twotikzpictures (emdedded assvg images) to give a visual representation of strongly connected components and the condensation graph. The LaTeX source is included.
  • Improved English grammar and general text flow throughout the article.
  • Changed the font from e.g.$order$ toorder where appropriate. Similarly, changed$tout[v]$ and$tin[v]$ to$t_\text{out}[v]$ and$t_\text{in}[v]$.
  • Merged the twoImplementation code blocks into one block. (The second block contained code that should have been in themain function in the first block. Therefore I thought it is cleaner to just put it in a single block.)
  • Added comments to the code.
  • Fixed some other small things:
    • The article mentioned the graphs$g$ and$gr$ even though these were never used.
    • The article did not give a clear definition of$t_\text{out}[v]$ and$t_\text{in}[v]$.
    • The article said that sorting all vertices in$G$ by exit time is equivalent to topologically sorting the vertices of$G$. (This is wrong, because$G$ is not necessarily a DAG.)

For the addedtikzpictures, the source code andsvg files themselves are in a new directorysrc/graph/strongly-connected-components-tikzpicture.

Let me know what you think!

@github-actionsGitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (for commit57a5017):

https://cp-algorithms--preview-1307-doz6kdtp.web.app

(expires 2024-07-18T14:32:14.340265812Z)

Copy link
Member

@adamant-pwnadamant-pwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi, thank you very much, I think it's a significant improvement! Could you please go over review comments before we merge this?

@el-sambal
Copy link
ContributorAuthor

Thanks for your suggestions!

@github-actionsGitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (for commit9054c35):

https://cp-algorithms--preview-1307-doz6kdtp.web.app

(expires 2024-07-23T00:49:57.826813480Z)

@github-actionsGitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (for commitd45b892):

https://cp-algorithms--preview-1307-doz6kdtp.web.app

(expires 2024-07-23T01:09:10.072101203Z)

@github-actionsGitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (for commit15b6f5b):

https://cp-algorithms--preview-1307-doz6kdtp.web.app

(expires 2024-07-23T01:10:37.607076414Z)

Copy link
Member

@adamant-pwnadamant-pwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

el-sambal reacted with thumbs up emoji
@adamant-pwnadamant-pwn merged commitedea689 intocp-algorithms:masterJul 16, 2024
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@adamant-pwnadamant-pwnadamant-pwn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@el-sambal@adamant-pwn

[8]ページ先頭

©2009-2025 Movatter.jp