Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

complex test case to find outer planar graph face#1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
adamhosticka wants to merge2 commits intocp-algorithms:mainfromadamhosticka:master

Conversation

adamhosticka
Copy link

Finding outer face in a more complex graphs doesn't work.

@adamant-pwn
Copy link
Member

Hi, thanks for the pull request! But I'm a bit confused, so you mean that the current implementation is incorrect? Is it possible for you to also add a fix for it in such a case?

@github-actionsGitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (for commit922cb9b):

https://cp-algorithms--preview-1258-sdg06vwe.web.app

(expires 2024-04-24T21:46:51.216932235Z)

@adamhosticka
Copy link
Author

Yes, I believe there is an error. Unfortunately I do not have the time right now create a fix in cpp. I am coding in Python and managed to create a workaround, but I am not even sure it is correct. All I can provide right now is the comment I have added to my code 2 weeks ago:

The sourced algorithm contains an error when finding the outer face. It cannot be just found by checking the orientation
of the vertices. Therefore, I changed the logic.
First we find the outer face candidates - these are the faces containing all the vertices.
The outer face is then the face with the least vertices.
Proof by dispute:
The face with more verticesf1 must contain at least one extra vertexv.
This vertex lies inside the face with fewer verticesf2.
If we create a new facef3 by splitting any edge (a,b) of thef2 into (a,v)&(v,b),
then the edge (a,b) won't lie in the new facef3.
Therefore, the extra vertexv is not a part of the outer face.
Repeat for all extra vertices.

@adamant-pwnadamant-pwn deleted the branchcp-algorithms:mainOctober 14, 2024 18:52
@adamant-pwnadamant-pwn changed the base branch frommaster tomainOctober 14, 2024 19:19
@github-actionsGitHub Actions
Copy link
Contributor

Preview the changes for PR#1258 athttps://gh.cp-algorithms.com/1258/ (current version:c7a8dd7).

@adamant-pwn
Copy link
Member

Allegedly fixed in#1394.

github-actionsbot added a commit that referenced this pull requestJan 13, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@adamhosticka@adamant-pwn

[8]ページ先頭

©2009-2025 Movatter.jp