Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

added range update code#1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
A-stick-bug wants to merge5 commits intocp-algorithms:main
base:main
Choose a base branch
Loading
fromA-stick-bug:patch-2

Conversation

A-stick-bug
Copy link

Added sqrt decomposition code that supports both range updates and range queries in O(sqrt(n))

@github-actionsGitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (for commit603e7ea):

https://cp-algorithms--preview-1204-f0s8g2k4.web.app

(expires 2023-12-27T02:26:54.469890884Z)

@adamant-pwn
Copy link
Member

Thanks for the pull request! I have few concerns here:

  1. At the moment the implementation is just dumped in the middle of the paragraph without any further explanation. The paragraph itself uses names$b$ and$c$ for arrays, which is obviously inconsistent with the names used in the code, and should be fixed to provide a better continuity.
  2. I'm not sure whether Python implementation is particularly useful. Was it tried on specific problems? How does it fare against C++ implementations? Sqrt decomposition often has a large constant time factor, and with Python it might be even worse...

@adamant-pwn
Copy link
Member

@A-stick-bug hi, do you plan any further work on this pull request?

@A-stick-bug
Copy link
Author

A-stick-bug commentedJan 5, 2024 via email

I will write it in c++ some time this weekend and make it consistent withthe rest of the code. Also, I tested it on this question: DMOPC '15 Contest1 P6 - Lelei and Contest - DMOJ: Modern Online Judge<https://dmoj.ca/problem/dmopc15c1p6>
…
On Thu, Jan 4, 2024 at 8:40 AM Oleksandr Kulkov ***@***.***> wrote:@A-stick-bug <https://github.com/A-stick-bug> hi, do you plan any further work on this pull request? — Reply to this email directly, view it on GitHub <#1204 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AY7C6JUX4EPINTAGTPL4KH3YM2WLBAVCNFSM6AAAAABAL2LUKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXGEYTCNBTG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

@adamant-pwnadamant-pwn deleted the branchcp-algorithms:mainOctober 14, 2024 18:52
@adamant-pwnadamant-pwn changed the base branch frommaster tomainOctober 14, 2024 19:20
@github-actionsGitHub Actions
Copy link
Contributor

Preview the changes for PR#1204 (for commit8f52f11) athttps://gh.cp-algorithms.com/1204/.

@mhayter
Copy link
Contributor

updates?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@A-stick-bug@adamant-pwn@mhayter
[8]ページ先頭
©2009-2025 Movatter.jp