Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.8k
Create golden_search_ratio#1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jakobkogler left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hallo, thanks for submitting a pull request.
But before I accept this one, you will need to make a lot of changes. As the pull request is not useful for the project in the current state.
About the content
- Clearly describe what problem that you are even trying to solve. It's probably finding the maximum value in an array that represents a unimodal function. But that's only "partly" mentioned in a side sentence. Nobody that starts reading the article will know what that algorithm is even useful for.
- You say, that you choose two points
$m_1$ and$m_2$ via the equation. But what do you do with those points? - Is this related to theternary search algorithm? It might even make sense to extend that article, instead of writing a new one.
- What's the benefit of
$\phi$ in this algorithm? Why is it vital? Ternary search also has complexity$O(\log N)$ , similar to this golden-section search. - An implementation would certainly help, as it's not trivial (and in the current form not understandable).
- Take a look at our other pages, on how we structure example problems. It's never in the form of problem statement / input / output and we almost never read input/output via cin.
- The problem not even closely related to the golden-section search algorithm, therefore it doesn't make any sense to include it in an article about the golden-section algorithm.
About the technical stuff
- Read through thecontribution page, especially the general information section and the syntax section.
- Test if you page is rendered correctly via ourpreview page.
Basically there are a lot of technical things wrong.
Note that there is another PR (#1119) which adds a paragraph about golden search to the ternary search article. |
jxu commentedOct 15, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Golden-section search does the same as ternary search, except each iteration the interval size is multiplied by 1/phi = 0.618... instead of 2/3 = 0.666.... The Wikipedia page is way too verbose. Both run in O(log n) time so I don't think there's much practical benefit. |
I'm closing this as a stale Pull Request. Per Jakob's rationale, and also because#1119 addresses the same issues, and, IMO, at a higher quality level. |
No description provided.