Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Create golden_search_ratio#1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Shubhamkashyap1601 wants to merge1 commit intocp-algorithms:masterfromShubhamkashyap1601:master
Closed

Create golden_search_ratio#1159

Shubhamkashyap1601 wants to merge1 commit intocp-algorithms:masterfromShubhamkashyap1601:master

Conversation

Shubhamkashyap1601
Copy link

No description provided.

Copy link
Member

@jakobkoglerjakobkogler left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hallo, thanks for submitting a pull request.

But before I accept this one, you will need to make a lot of changes. As the pull request is not useful for the project in the current state.

About the content

  1. Clearly describe what problem that you are even trying to solve. It's probably finding the maximum value in an array that represents a unimodal function. But that's only "partly" mentioned in a side sentence. Nobody that starts reading the article will know what that algorithm is even useful for.
  2. You say, that you choose two points$m_1$ and$m_2$ via the equation. But what do you do with those points?
  3. Is this related to theternary search algorithm? It might even make sense to extend that article, instead of writing a new one.
  4. What's the benefit of$\phi$ in this algorithm? Why is it vital? Ternary search also has complexity$O(\log N)$, similar to this golden-section search.
  5. An implementation would certainly help, as it's not trivial (and in the current form not understandable).
  6. Take a look at our other pages, on how we structure example problems. It's never in the form of problem statement / input / output and we almost never read input/output via cin.
  7. The problem not even closely related to the golden-section search algorithm, therefore it doesn't make any sense to include it in an article about the golden-section algorithm.

About the technical stuff

  1. Read through thecontribution page, especially the general information section and the syntax section.
  2. Test if you page is rendered correctly via ourpreview page.

Basically there are a lot of technical things wrong.

  • The file isn't organized into any directory. You could put it in the same directory as the binary search article.
  • The file doesn't have a file ending.
  • Our project uses Markdown and Latex for formatting, your page doesn't, which renders it really badly:
    image

@adamant-pwn
Copy link
Member

Note that there is another PR (#1119) which adds a paragraph about golden search to the ternary search article.

@jxu
Copy link
Contributor

jxu commentedOct 15, 2023
edited
Loading

Golden-section search does the same as ternary search, except each iteration the interval size is multiplied by 1/phi = 0.618... instead of 2/3 = 0.666.... The Wikipedia page is way too verbose. Both run in O(log n) time so I don't think there's much practical benefit.

@adamant-pwn
Copy link
Member

I'm closing this as a stale Pull Request. Per Jakob's rationale, and also because#1119 addresses the same issues, and, IMO, at a higher quality level.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jakobkoglerjakobkoglerjakobkogler requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@Shubhamkashyap1601@adamant-pwn@jxu@jakobkogler

[8]ページ先頭

©2009-2025 Movatter.jp