Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add a configuration option to allow block tags to be excluded by regex#93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
rebkwok wants to merge3 commits intocoveragepy:main
base:main
Choose a base branch
Loading
fromopensafely-core:master

Conversation

@rebkwok
Copy link

Thanks for this plugin, which did almost exactly what we needed, apart from one issue, which this PR is an attempt to address.

The issue we had was that our project is usingslippers, which means we have component tags in our templates with start/end block tags that don't follow the usual django convention for the end tag ({% end<...> %}). Instead they look something like

{% #card %}...{% /card %}

This means that any component end tag on its own line gets marked as uncovered.

This PR adds a config optionexclude_blocks which takes a list of regexes, similar toexclude_also in the main coverage config, and allow us to specify patterns to match and exclude the content of block tags. With the following pyproject.toml config, we can now exclude any block tags that start with "/" (ie slippers component end tags).

[tool.coverage.django_coverage_plugin]template_extensions = "html"exclude_blocks = [    "\\/\\w+"]

I didn't add a similar exclude option for text tags because there's additional complexity there since a text tag can span multiple lines (and I haven't seen issues that suggest it's a feature anyone needs yet)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rebkwok

[8]ページ先頭

©2009-2025 Movatter.jp