Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.1k
feat(images): add referrerpolicy attribute for privacy protection#2588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
AldenWangExis wants to merge2 commits intocotes2020:masterChoose a base branch fromAldenWangExis:feat/img-referrerpolicy
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+5 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add <meta name="referrer" content="never"> to document headfor enhanced privacy protection and hotlink bypass capability.This prevents browsers from sending HTTP Referer headers whenloading external resources, particularly useful for:- Displaying images from platforms with referrer-based hotlink protection- Reducing information leakage to third-party servers- Enhancing user privacyImplements W3C Referrer Policy specification.
Inject referrerpolicy="no-referrer" to image tags in:- refactor-content.html: post content images- sidebar.html: avatar imagePrevents Referer header leakage and enables displaying imagesfrom platforms with referrer-based hotlink protection.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Type of change
Description
This PR adds referrer policy support to prevent HTTP Referer headers from being sent when loading images. This enhancement is particularly useful for:
Changes Made
1. Meta Tag in Head (head.html)
Added
<meta name="referrer" content="never">to the document head for global referrer policy.2. Image Tag Attributes (refactor-content.html)
Modified the image processing logic to inject
referrerpolicy="no-referrer"attribute to all dynamically generated<img>tags in post content.3. Sidebar Avatar (sidebar.html)
Added
referrerpolicy="no-referrer"attribute to the avatar image in the sidebar.Additional context
Opened#2586
Testing
Tested with:
Branch Information
master(or latest release branch)feat/img-referrerpolicy