Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add edit this post link#2517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
kungfux wants to merge1 commit intocotes2020:master
base:master
Choose a base branch
Loading
fromkungfux:feature/edit-this-post-link

Conversation

@kungfux
Copy link
Collaborator

Type of change

  • New feature (non-breaking change which adds functionality)

Description

Add "Edit this post" link at the bottom of the post, so it is easier for users to contibute to the blog content.
The feature is disabled by default and should be enabled and configured by editing_data/edit-this-post.yml.

Additional context

Closes#2067

Demo

image

Copy link
Owner

@cotes2020cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! This seems like an interesting feature, but blog and documentation websites have different purposes. Most people wouldn't invite others to modify their posts, so the priority for implementing this feature isn't very urgent.

The current PR design, placing new links at the bottom of posts, looks a bit cluttered. I plan to revisit this feature once I have time to think of a cleaner UI layout.

lextm reacted with thumbs up emoji
@kungfux
Copy link
CollaboratorAuthor

Thanks! I mainly wanted to experiment with implementing this feature since there was a request for it. I completely agree with your points, the feature definitely needs some refinement, as you mentioned. I also understand that people might use the theme differently from what was originally intended, so it could still be useful in some cases. Anyway, I'll rely on your decision regarding how to proceed. No hard feelings 😀

cotes2020 reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cotes2020cotes2020cotes2020 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add "Edit this post" link

2 participants

@kungfux@cotes2020

[8]ページ先頭

©2009-2025 Movatter.jp