Commit0330814

committed

refactor(CDropdown): minor improvements

1 parent1154cd2 commit0330814Copy full SHA for 0330814

File tree

1 file changed

+16

-5

lines changed

packages/coreui-vue/src/components/dropdown
- CDropdown.ts

1 file changed

+16

-5

lines changed

`‎packages/coreui-vue/src/components/dropdown/CDropdown.ts‎`

Lines changed: 16 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,15 @@`
`1`		`-import{defineComponent,h,nextTick,onUnmounted,provide,PropType,ref,Ref,watch}from'vue'`
	`1`	`+import{`
	`2`	`+computed,`
	`3`	`+defineComponent,`
	`4`	`+h,`
	`5`	`+nextTick,`
	`6`	`+onUnmounted,`
	`7`	`+provide,`
	`8`	`+PropType,`
	`9`	`+ref,`
	`10`	`+Ref,`
	`11`	`+watch,`
	`12`	`+}from'vue'`
`2`	`13`	`importtype{Placement}from'@popperjs/core'`
`3`	`14`
`4`	`15`	`import{usePopper}from'../../composables'`
`@@ -54,7 +65,7 @@ const CDropdown = defineComponent({`
`54`	`65`	* - `'outside'` - the dropdown will be closed (only) by clicking outside the dropdown menu.
`55`	`66`	`*/`
`56`	`67`	`autoClose:{`
`57`		`-type:[Boolean,String],`
	`68`	`+type:[Boolean,String]asPropType<boolean\|'inside'\|'outside'>,`
`58`	`69`	`default:true,`
`59`	`70`	`validator:(value:boolean\|string)=>{`
`60`	`71`	`returntypeofvalue==='boolean'\|\|['inside','outside'].includes(value)`
`@@ -181,7 +192,7 @@ const CDropdown = defineComponent({`
`181`	`192`
`182`	`193`	`const{ initPopper, destroyPopper}=usePopper()`
`183`	`194`
`184`		`-constpopperConfig={`
	`195`	`+constpopperConfig=computed(()=>({`
`185`	`196`	`modifiers:[`
`186`	`197`	`{`
`187`	`198`	`name:'offset',`
`@@ -196,7 +207,7 @@ const CDropdown = defineComponent({`
`196`	`207`	`props.alignment,`
`197`	`208`	`isRTL(dropdownMenuRef.value)`
`198`	`209`	`)asPlacement,`
`199`		`-}`
	`210`	`+}))`
`200`	`211`
`201`	`212`	`watch(`
`202`	`213`	`()=>props.visible,`
`@@ -213,7 +224,7 @@ const CDropdown = defineComponent({`
`213`	`224`	`dropdownRef`
`214`	`225`	`)`
`215`	`226`	`if(referenceElement&&popper.value){`
`216`		`-initPopper(referenceElement,dropdownMenuRef.value,popperConfig)`
	`227`	`+initPopper(referenceElement,dropdownMenuRef.value,popperConfig.value)`
`217`	`228`	`}`
`218`	`229`
`219`	`230`	`window.addEventListener('click',handleClick)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit0330814

File tree

1 file changed

1 file changed

`‎packages/coreui-vue/src/components/dropdown/CDropdown.ts‎`

0 commit comments