[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:iTrooz
Once this PR has been reviewed and has the lgtm label, please assignluap99 for approval. For more information seethe Code Review Process.

The full list of commands accepted by this bot can be foundhere.

I assume this change should be submitted againsthttps://github.com/containers/buildah instead. But where am I supposed to put tests ? Should they stay in this repository ?

I assume this change should be submitted againsthttps://github.com/containers/buildah instead. But where am I supposed to put tests ? Should they stay in this repository ?

https://github.com/containers/buildah/blob/main/tests/bud.bats for example. Givent he same build command is eposed in buildah you should be able to to just add tests there. Once that is merged in buildah and we updated buildah here we can still have like one or two cases to validate that podman produces the same expected errors.

For when you port this over to buildah: I wonder if a check that/dev/stdout is not a TTY is appropriate? Streaming a tar file to the terminal isn't very useful, so we want to make sure the user is redirecting to a file or piping to another process.

Done !containers/buildah#6476

I wonder if a check that /dev/stdout is not a TTY is appropriate?

Probably, especially since docker does it. I could submit this in a separate PR, but I'd like to keep this one focused on this