Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Artifacts] Podman artifacts should support emitting events#27324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
nimdrak wants to merge9 commits intocontainers:main
base:main
Choose a base branch
Loading
fromnimdrak:27260-2

Conversation

@nimdrak
Copy link
Contributor

@nimdraknimdrak commentedOct 20, 2025•
edited
Loading

Does this PR introduce a user-facing change?

Fixed#27260

- Added support for artifact events in podman events. - Users can now monitor artifact operations (pull, push, add, remove, extract) using podman events --filter type=artifact. - This feature works with both journald and file event backends and displays artifact names, digests, and operation details.

containers/container-libs#418 should be merget at first and reflected in this PR.

@openshift-ci
Copy link
Contributor

[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:nimdrak
Once this PR has been reviewed and has the lgtm label, please assignluap99 for approval. For more information seethe Code Review Process.

The full list of commands accepted by this bot can be foundhere.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

@nimdraknimdrak marked this pull request as draftOctober 20, 2025 13:35
@openshift-ciopenshift-cibot added the do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress. labelOct 20, 2025
@packit-as-a-service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

}
returnnil,err
}
ir.Libpod.NewArtifactEvent(events.Remove,"",namesOrDigest,nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

These should probably go in libartifact in containers/container-libs - pass it in when creating a new instance of an artifact store (athttps://github.com/containers/container-libs/blob/main/common/pkg/libartifact/store/store.go#L50) and go from there

nimdrak reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you so much! It looks much better.
How about this one?83b6234.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry, I misunderstood your review at first. But I got it now.

@openshift-merge-robotopenshift-merge-robot added the needs-rebaseIndicates a PR cannot be merged because it has merge conflicts with HEAD. labelOct 21, 2025
@openshift-merge-robotopenshift-merge-robot removed the needs-rebaseIndicates a PR cannot be merged because it has merge conflicts with HEAD. labelOct 21, 2025
@nimdraknimdrak marked this pull request as ready for reviewOctober 23, 2025 12:55
@openshift-ciopenshift-cibot removed the do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress. labelOct 23, 2025
@nimdraknimdrak marked this pull request as draftOctober 23, 2025 12:55
@openshift-ciopenshift-cibot added the do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress. labelOct 23, 2025
…g.goSigned-off-by: ByoungUk Lee <nimdrak@gmail.com>
…ents.goSigned-off-by: ByoungUk Lee <nimdrak@gmail.com>
…urnal_linux.goSigned-off-by: ByoungUk Lee <nimdrak@gmail.com>
…gfile.goSigned-off-by: ByoungUk Lee <nimdrak@gmail.com>
Signed-off-by: ByoungUk Lee <nimdrak@gmail.com>
Signed-off-by: ByoungUk Lee <nimdrak@gmail.com>
    Signed-off-by: ByoungUk Lee <nimdrak@gmail.com>
Signed-off-by: ByoungUk Lee <nimdrak@gmail.com>
    Signed-off-by: ByoungUk Lee <nimdrak@gmail.com>
@nimdraknimdrak marked this pull request as ready for reviewOctober 27, 2025 03:45
@openshift-ciopenshift-cibot removed the do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress. labelOct 27, 2025
@nimdraknimdrak marked this pull request as draftNovember 5, 2025 07:57
@openshift-ciopenshift-cibot added the do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress. labelNov 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@mheonmheonmheon left review comments

Assignees

No one assigned

Labels

do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress.release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Artifacts] Podman artifacts should support emitting events

3 participants

@nimdrak@mheon@openshift-merge-robot
[8]ページ先頭
©2009-2025 Movatter.jp