- Notifications
You must be signed in to change notification settings - Fork123
Fix gui_vm compilation + warning, missing examples/Cargo.lock#416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
1fefdbe to698c252Compare
jakecorrenti left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code LGTM.
I think it would be nice for the first commit to just have a quick message saying which packages were updated/added, but that's just me.
mtjhrc commentedSep 25, 2025
Sure done. To clarify though, the the packages were already "updated" (cargo build would use the newer versions) - we were just missing the Cargo.lock to lock the minor versions and hashes. |
jakecorrenti left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm.
Seems there's an issue with the CI, though.
mtjhrc commentedSep 25, 2025
Yeah, I'm looking into the CI, but this PR doesn't touch the integration test compilation which broke at all. (so I guess it broke when the rust tool chain updates itself?), weird... |
Commit newly generated Cargo.lock. It was missing an update to nix, cfg-if andcfg_aliases crates.Signed-off-by: Matej Hrica <mhrica@redhat.com>
Signed-off-by: Matej Hrica <mhrica@redhat.com>
Signed-off-by: Matej Hrica <mhrica@redhat.com>
186c220 intocontainers:mainUh oh!
There was an error while loading.Please reload this page.
No description provided.