- Notifications
You must be signed in to change notification settings - Fork83
Client.Call(): do not return error if no Status is set (gRPC v1.23 and up)#46
Merged
dmcgowan merged 1 commit intocontainerd:masterfromAug 26, 2019
Merged
Conversation
…d up)To account forgrpc/grpc-go@5da5b1f,which is part of gRPC v1.23.0 and up, and after which gRPC no longer sets aStatus if no error occured.Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
MemberAuthor
thaJeztah commentedAug 26, 2019
@stevvooe@crosbymichael PTAL - this relates tocontainerd/containerd#3581; not sure if there are situations where this may happen in a non-error situation |
Member
crosbymichael commentedAug 26, 2019
LGTM |
Member
dmcgowan commentedAug 26, 2019
LGTM If this change is included with an older gRPC version, will it break? |
MemberAuthor
thaJeztah commentedAug 26, 2019
I don't think itbreaks - IIUC, the |
Member
stevvooe commentedAug 27, 2019
This doesn’t seem right. How is it a part of a cve? |
MemberAuthor
thaJeztah commentedAug 27, 2019
@stevvooe unfortunately, this change in behavior got rolle up in the v1.23 release, which also addresses those CVEs |
thaJeztah added a commit to thaJeztah/docker that referenced this pull requestAug 28, 2019
full diff:containerd/ttrpc@699c4e4...92c8520changes:-containerd/ttrpc#37 Handle EOF to prevent file descriptor leak-containerd/ttrpc#38 Improve connection error handling-containerd/ttrpc#40 Support headers-containerd/ttrpc#41 Add client and server unary interceptors-containerd/ttrpc#43 metadata as KeyValue type-containerd/ttrpc#42 Refactor close handling for ttrpc clients-containerd/ttrpc#44 Fix method full name generation-containerd/ttrpc#46 Client.Call(): do not return error if no Status is set (gRPC v1.23 and up)-containerd/ttrpc#49 Handle ok statusSigned-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull requestSep 3, 2019
full diff:containerd/ttrpc@699c4e4...92c8520changes:-containerd/ttrpc#37 Handle EOF to prevent file descriptor leak-containerd/ttrpc#38 Improve connection error handling-containerd/ttrpc#40 Support headers-containerd/ttrpc#41 Add client and server unary interceptors-containerd/ttrpc#43 metadata as KeyValue type-containerd/ttrpc#42 Refactor close handling for ttrpc clients-containerd/ttrpc#44 Fix method full name generation-containerd/ttrpc#46 Client.Call(): do not return error if no Status is set (gRPC v1.23 and up)-containerd/ttrpc#49 Handle ok statusSigned-off-by: Sebastiaan van Stijn <github@gone.nl>Upstream-commit: 8769255d1bb9c469d4f2966e7e9869a9f126f9e9Component: engine
thaJeztah added a commit to thaJeztah/docker that referenced this pull requestSep 12, 2019
full diff:containerd/ttrpc@699c4e4...92c8520changes:-containerd/ttrpc#37 Handle EOF to prevent file descriptor leak-containerd/ttrpc#38 Improve connection error handling-containerd/ttrpc#40 Support headers-containerd/ttrpc#41 Add client and server unary interceptors-containerd/ttrpc#43 metadata as KeyValue type-containerd/ttrpc#42 Refactor close handling for ttrpc clients-containerd/ttrpc#44 Fix method full name generation-containerd/ttrpc#46 Client.Call(): do not return error if no Status is set (gRPC v1.23 and up)-containerd/ttrpc#49 Handle ok statusSigned-off-by: Sebastiaan van Stijn <github@gone.nl>(cherry picked from commit8769255)Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull requestSep 23, 2019
full diff:containerd/ttrpc@699c4e4...92c8520changes:-containerd/ttrpc#37 Handle EOF to prevent file descriptor leak-containerd/ttrpc#38 Improve connection error handling-containerd/ttrpc#40 Support headers-containerd/ttrpc#41 Add client and server unary interceptors-containerd/ttrpc#43 metadata as KeyValue type-containerd/ttrpc#42 Refactor close handling for ttrpc clients-containerd/ttrpc#44 Fix method full name generation-containerd/ttrpc#46 Client.Call(): do not return error if no Status is set (gRPC v1.23 and up)-containerd/ttrpc#49 Handle ok statusSigned-off-by: Sebastiaan van Stijn <github@gone.nl>(cherry picked from commit 8769255d1bb9c469d4f2966e7e9869a9f126f9e9)Signed-off-by: Sebastiaan van Stijn <github@gone.nl>Upstream-commit: 525e8ed3febff46d07cb01961601824b5f8b301bComponent: engine
burnMyDread pushed a commit to burnMyDread/moby that referenced this pull requestOct 21, 2019
full diff:containerd/ttrpc@699c4e4...92c8520changes:-containerd/ttrpc#37 Handle EOF to prevent file descriptor leak-containerd/ttrpc#38 Improve connection error handling-containerd/ttrpc#40 Support headers-containerd/ttrpc#41 Add client and server unary interceptors-containerd/ttrpc#43 metadata as KeyValue type-containerd/ttrpc#42 Refactor close handling for ttrpc clients-containerd/ttrpc#44 Fix method full name generation-containerd/ttrpc#46 Client.Call(): do not return error if no Status is set (gRPC v1.23 and up)-containerd/ttrpc#49 Handle ok statusSigned-off-by: Sebastiaan van Stijn <github@gone.nl>Signed-off-by: zach <Zachary.Joyner@linux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To account forgrpc/grpc-go@5da5b1f (grpc/grpc-go#2929),
which is part of gRPC v1.23.0 and up, and after which gRPC no longer sets a
Status if no error occured.