Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Admin client impl fixes#1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
siobhan-sterrett wants to merge4 commits intoconfluentinc:master
base:master
Choose a base branch
Loading
fromsiobhan-sterrett:admin-client-impl-fixes

Conversation

siobhan-sterrett
Copy link

A handful of minor fixes to cimpl. Probably nothing that will impact real-life use-cases, since these are all buried inside_AdminClientImpl, but they were bothering me.

  1. Swaps"topic_names" and"future" inkws array inAdmin_describe_topics()

If a user tried to passtopic_names orfuture into_AdminClientImpl.describe_topics() as keyword arguments, they would end up swapped, which would lead to confusing errors.

  1. RaisesTypeError inAdmin_list_consumer_group_offset() ifrequest is not a list
  2. RaisesTypeError inAdmin_alter_consumer_group_offsets() ifrequest is not a list

In both of these cases, the library would raiseValueError ifrequest was a list with anything other than 1 item... but ifrequest wasn't a list, it would result in an internal error when it tried to access its first item.

  1. Allows elements ofplist inpy_to_c_parts() to be instances of a subtype ofTopicPartition

If a user passed a list of instances of a subtype ofTopicPartition, the library would raise aTypeError, even if the instances were otherwise valid.

@cla-assistantCLA Assistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.


Siobhán Sterrett seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, pleaseadd the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let usrecheck it.

1 similar comment
@cla-assistantCLA Assistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.


Siobhán Sterrett seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, pleaseadd the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let usrecheck it.

@joaoe
Copy link

I think this might touch some code I changed here
#1591

But this project is not accepting PRs. It's annoying.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@siobhan-sterrett@joaoe

[8]ページ先頭

©2009-2025 Movatter.jp