- Notifications
You must be signed in to change notification settings - Fork46
mkcomposefs: handle failed_path NULL from lcfs_build()#424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
cgwalters merged 1 commit intocomposefs:mainfromeriksjolund:mkcomposefs-handle-failed_path-NULLMay 18, 2025
Merged
mkcomposefs: handle failed_path NULL from lcfs_build()#424
cgwalters merged 1 commit intocomposefs:mainfromeriksjolund:mkcomposefs-handle-failed_path-NULLMay 18, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
cgwalters approved these changesMay 18, 2025
Uh oh!
There was an error while loading.Please reload this page.
20b051f toaaf14d4Comparelcfs_build() might have set failed_path to NULL. This couldhappen if maybe_join_path() returns NULL due to a malloc() failure.If this happens, use an empty string to avoid segfaulting in err().Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
aaf14d4 to91da735Comparec34cd51 intocomposefs:main 8 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
lcfs_build()might have setfailed_pathtoNULL. This could happen ifmaybe_join_path()returnsNULLdue to amalloc()failure. If this happens, use an empty string to avoid segfaulting inerr().I spotted this when I was reading the code. I hope the analysis is correct. I think it's better to use the somewhat confusing error message
error accessingthan segfaulting.