NotificationsYou must be signed in to change notification settings
Fork46
Star604

Commitd0dc993

committed

tests/should-fail: Verify exit code 1

Some of these runs were exiting with SIGSEGV but because wewere just checking that the command failed, we masked that error...Fix the test code here to verify that the process exited with code 1.Signed-off-by: Colin Walters <walters@verbum.org>

1 parentc0591cd commitd0dc993Copy full SHA for d0dc993

File tree

1 file changed

-1

lines changed

tests
- test-should-fail.sh

1 file changed

-1

lines changed

`‎tests/test-should-fail.sh‎`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -7,8 +7,14 @@ shift`
`7`	`7`	`tmpd=$(mktemp -d -t lcfs-test.XXXXXX)`
`8`	`8`	`trap'rm -rf -- "$tmpd"' EXIT`
`9`	`9`	`forfin$@;do`
`10`		`-if$bindir/mkcomposefs --from-file$f$tmpd/out.cfs&>/dev/null;then`
	`10`	`+ rc=0`
	`11`	`+$bindir/mkcomposefs --from-file$f$tmpd/out.cfs>/dev/null2>$tmpd/err.txt\|\| rc=$?`
	`12`	`+iftest$rc == 0;then`
`11`	`13`	`fatal"Test case$f should have failed"`
`12`	`14`	`fi`
	`15`	`+iftest$rc!= 1;then`
	`16`	`+ cat$tmpd/err.txt`
	`17`	`+ fatal"Test case$f exited with code$rc, not 1"`
	`18`	`+fi`
`13`	`19`	`echo"ok$f"`
`14`	`20`	`done`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd0dc993

File tree

1 file changed

1 file changed

`‎tests/test-should-fail.sh‎`

0 commit comments