Movatterモバイル変換

core: map Etc/* timezones to 'host' for pct compatibility#10020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Conversation

Copy link

Member

MickLesk commentedDec 16, 2025

✍️ Description

pct create --timezone only accepts timezones from zone.tab or the special value 'host'. Etc/* zones (like Etc/UTC) are valid Linux timezones but not accepted by pct, causing container creation to fail with 'invalid time zone' error.

This change automatically maps any Etc/* timezone to 'host', which inherits the host's timezone - giving users the expected behavior when their Proxmox host is set to Etc/UTC.

🔗 Related Issue

Fixes#9974

✅ Prerequisites (X in brackets)

Self-review completed – Code follows project standards.
Tested thoroughly – Changes work as expected.
No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

🐞Bug fix – Resolves an issue without breaking functionality.
✨New feature – Adds new, non-breaking functionality.
💥Breaking change – Alters existing functionality in a way that may require updates.
🆕New script – A fully functional and tested script or script set.
🌍Website update – Changes to website-related JSON files or metadata.
🔧Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
📝Documentation update – Changes toREADME,AppName.md,CONTRIBUTING.md, or other docs.

MickLesk requested a review froma team as acode owner

December 16, 2025 09:22

github-actionsbot added core feature labels

Dec 16, 2025

MickLesk force-pushed thefix/timezone-etc-utc-fallback branch from421fe79 tofd4e6f4Compare

December 16, 2025 09:22

fix(build): map Etc/* timezones to 'host' for pct compatibility

62ab46a

pct create --timezone only accepts timezones from zone.tab or thespecial value 'host'. Etc/* zones (like Etc/UTC) are valid Linuxtimezones but not accepted by pct, causing container creation to failwith 'invalid time zone' error.This change automatically maps any Etc/* timezone to 'host' at:- Host timezone detection (advanced_settings)- var_timezone from App Defaults- base_settings() for default path- pct create command buildingThis ensures consistent behavior: users see 'host' in the UI,App Defaults save 'host', and container creation succeeds.

MickLesk force-pushed thefix/timezone-etc-utc-fallback branch fromfd4e6f4 to62ab46aCompare

December 16, 2025 09:28