Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(changelog): add support for multiline BREAKING paragraph#348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
woile merged 1 commit intomasterfromfeat/multiline-body
Feb 21, 2021

Conversation

@woile
Copy link
Member

@woilewoile commentedFeb 19, 2021•
edited
Loading

Description

Checklist

  • Add test cases to all the changes you introduce
  • Run./script/format and./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Support for multiline body, suppose a commit message like this:

fix: user issueBREAKING CHANGE: this should be all picked up by commitizen itself, whenI do a new line like this, it will be included in the end result changelognot this

Commitizen will detect afix and aBREAKING CHANGE
both will be added to the changelog

Steps to Test This Pull Request

  1. Create a commit like the example above
  2. Runcz changelog
  3. Observecat CHANGELOG.md

Additional context

Closes#346

@codecov
Copy link

codecovbot commentedFeb 19, 2021•
edited
Loading

Codecov Report

Merging#348 (0621bc4) intomaster (1605d69) willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff           @@##           master     #348   +/-   ##=======================================  Coverage   97.29%   97.29%           =======================================  Files          35       35             Lines         999      999           =======================================  Hits          972      972             Misses         27       27
FlagCoverage Δ
unittests97.29% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update2387ea7...0621bc4. Read thecomment docs.

@woile
Copy link
MemberAuthor

I'm aware I'm introducing a side-effect which I think is cool.

Given this commit message:

fix: user module now workfix: another fixBREAKING CHANGE: You have to fix `here` and `there`footer

Would output this CHANGELOG:

### Fix- user module now work- another fix### BREAKING CHANGE- You have to fix `here` and `there`

Copy link
Member

@Lee-WLee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just a minor suggestion. Other than that everything looks good to me 🙂

@woilewoile merged commit67c599e intomasterFeb 21, 2021
@woilewoile deleted the feat/multiline-body branchFebruary 21, 2021 10:10
@bearomorphismbearomorphism mentioned this pull requestSep 25, 2025
11 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Lee-WLee-WLee-W approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Breaking change should support multiline

3 participants

@woile@Lee-W
[8]ページ先頭
©2009-2025 Movatter.jp