Addressed the issues about missingskip_below_py_3_13 and missing forced consistent environment variables to reduce the chance of unnecessary file regression test failures.
Extracted duplicated logics.

bearomorphism requested review fromLee-W,noirbizarre andwoile ascode owners

December 13, 2025 03:03

github-actionsbot added the pr-status: wait-for-review label

Dec 13, 2025

Copy link

codecovbot commentedDec 13, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Pleaseupload report for BASE (v4-11-0@2072f8e).Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff             @@##             v4-11-0    #1726   +/-   ##==========================================  Coverage           ?   97.84%           ==========================================  Files              ?       60             Lines              ?     2604             Branches           ?        0           ==========================================  Hits               ?     2548             Misses             ?       56             Partials           ?        0

Flag	Coverage Δ
unittests	`97.84% <ø> (?)`

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bearomorphism force-pushed thetest-help branch 2 times, most recently from097ef1f to6c3ef01Compare

December 13, 2025 03:09

This was referencedDec 13, 2025

test: remove skip_below_py_3_10#1725

Closed

feat(version): add MANUAL_VERSION, --next and --patch to version comm…#1724

Open

bearomorphism force-pushed thetest-help branch from6c3ef01 toecd05a4Compare

December 13, 2025 03:15

test(commands): centralize all --help tests in a file to dedup code

ce12748

bearomorphism force-pushed thetest-help branch fromecd05a4 toce12748Compare

December 13, 2025 03:24

bearomorphism commented

Dec 13, 2025

View reviewed changes

tests/utils.py

Comment on lines -22 to -25

		skip_below_py_3_13=pytest.mark.skipif(
		sys.version_info< (3,13),
		reason="The output message of argparse is different between Python 3.13 and lower than Python 3.13",
		)

Copy link

CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The variable name itself does not reflect why we want to set this variable... this may make it hard for future contributors to understand the code correctly

bearomorphism commented

Dec 13, 2025

View reviewed changes

tests/commands/test_common_command.py

Comment on lines +41 to +46

		monkeypatch.setenv("COLUMNS","80")
		monkeypatch.setenv("TERM","dumb")
		monkeypatch.setenv("LC_ALL","C")
		monkeypatch.setenv("LANG","C")
		monkeypatch.setenv("NO_COLOR","1")
		monkeypatch.setenv("PAGER","cat")

Copy link

CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copied from AI output. I know COLUMNS is necessary, but not sure for the rest

Copy link

CollaboratorAuthor

bearomorphism commentedDec 14, 2025

@woile @Lee-W could you review this PR when you have a moment? This PR contains the resolution of error when someone is trying to update CLI--help description. Some other PRs updating CLI options have dependencies on this PR.

Thanks!

Copy link

Member

woile commentedDec 14, 2025

I don't understand what this is supposed to fix

Copy link

CollaboratorAuthor

bearomorphism commentedDec 14, 2025

I don't understand what this is supposed to fix

The behavior of--help of argparse is different in some cases between python 3.13 and below 3.13 as the message of originalskip_below_py_3_13 says. Some of--help tests still usesskip_below_py_3_10 before this PR, and those tests still pass in the pipeline luckily.

When we try to add new options to the CLI, the help text changes, and usually we runpytest --regen-all to regenerate the file_regression test file, but the regenerated content may be different depends on the local environment (monkeypatch in this PR addresses this issue).