Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor(RestructuredTest): rename variable, fix typo and remove unnecessary string copy#1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Lee-W merged 1 commit intocommitizen-tools:v4-9-2frombearomorphism:refactor-rst
Nov 8, 2025

Conversation

@bearomorphism
Copy link
Collaborator

@bearomorphismbearomorphism commentedSep 15, 2025
edited by Lee-W
Loading

Description

  • Rename variables
  • Fix the unbounded variableindex
  • Make some methods module functions
  • Fix typo
  • Remove the use of string slice (e.g.first[1:]) because it causes extra string copy

Similar changes in#1596

@codecov
Copy link

codecovbot commentedSep 15, 2025
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Pleaseupload report for BASE (v4-9-2@cc981fc).Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@##             v4-9-2    #1609   +/-   ##=========================================  Coverage          ?   98.25%           =========================================  Files             ?       58             Lines             ?     2690             Branches          ?        0           =========================================  Hits              ?     2643             Misses            ?       47             Partials          ?        0
FlagCoverage Δ
unittests98.25% <100.00%> (?)

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lee-WLee-W added this to the4.9.2 milestoneSep 15, 2025
@Lee-WLee-W changed the titlerefactor(RestructuredTest): rename variable, fix typo and remove unne…refactor(RestructuredTest): rename variable, fix typo and remove unnecessary string copyNov 8, 2025
@Lee-WLee-W changed the base branch frommaster tov4-9-2November 8, 2025 10:08
@Lee-WLee-W merged commitfefc48c intocommitizen-tools:v4-9-2Nov 8, 2025
18 checks passed
@Lee-WLee-W removed this from the4.10.1 milestoneNov 18, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Lee-WLee-WLee-W approved these changes

@woilewoileAwaiting requested review from woile

@noirbizarrenoirbizarreAwaiting requested review from noirbizarre

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bearomorphism@Lee-W

[8]ページ先頭

©2009-2025 Movatter.jp