Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(providers): add dart_provider#1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
TheAlbertDev wants to merge1 commit intocommitizen-tools:master
base:master
Choose a base branch
Loading
fromTheAlbertDev:feature/dart-version-provider

Conversation

@TheAlbertDev
Copy link

closes:#1563

Description

as title

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Runpoetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Runpoetry doc locally to ensure the documentation pages renders correctly
  • Check and fix any broken links (internal or external) in the documentation

When runningpoetry doc, any broken internal documentation links will be reported in the console output like this:

INFO    -  Doc file 'config.md' contains a link 'commands/bump.md#-post_bump_hooks', but the doc 'commands/bump.md' does not contain an anchor '#-post_bump_hooks'.

Expected Behavior

Version field in dart's pubspec.yaml file should also update when runningcz bump

Steps to Test This Pull Request

dart create your_package_namecd your_package_namecz initgit add.cz ccz bump

Additional Context

@codecov
Copy link

codecovbot commentedAug 1, 2025
edited
Loading

Codecov Report

❌ Patch coverage is97.43590% with1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.95%. Comparing base (120d514) to head (e1e7164).
⚠️ Report is 753 commits behind head on master.

Files with missing linesPatch %Lines
commitizen/commands/init.py80.00%1 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##           master    #1564      +/-   ##==========================================+ Coverage   97.33%   97.95%   +0.61%==========================================  Files          42       59      +17       Lines        2104     2742     +638     ==========================================+ Hits         2048     2686     +638  Misses         56       56
FlagCoverage Δ
unittests97.95% <97.43%> (+0.61%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

"charset-normalizer (>=2.1.0,<4)",
# Use the Python 3.11 and 3.12 compatible API: https://github.com/python/importlib_metadata#compatibility
"importlib-metadata >=8.0.0,<8.7.0 ; python_version < '3.10'",
"ruamel-yaml (>=0.18.14,<0.19.0)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

why this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The pubspec.yaml file in Dart contains fields both with and without quotes. ruamel.yaml extends PyYAML by offering more configuration options, such as setting style preferences for quotes — in this case, preserving the original ones.

@TheAlbertDevTheAlbertDevforce-pushed thefeature/dart-version-provider branch frome1e7164 to4dd2ac2CompareAugust 10, 2025 14:05
@Lee-W
Copy link
Member

@woile I think we're planning to make it separate from the core of commitizen? then I'll skip reviewing for now till we have that. or we can also merge it and separate it at a later point. let me know whether you want me to take a look first. Thanks 🙂

woile reacted with thumbs up emoji

@TheAlbertDevTheAlbertDevforce-pushed thefeature/dart-version-provider branch from4dd2ac2 to0f012abCompareAugust 17, 2025 06:43
@Lee-WLee-W marked this pull request as draftNovember 8, 2025 07:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Lee-WLee-WAwaiting requested review from Lee-WLee-W is a code owner

@noirbizarrenoirbizarreAwaiting requested review from noirbizarrenoirbizarre is a code owner

@woilewoileAwaiting requested review from woilewoile is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dart provider

3 participants

@TheAlbertDev@Lee-W@woile

[8]ページ先頭

©2009-2025 Movatter.jp