Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor(Init): fix unbounded variable in _ask_tag_format#1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bearomorphism wants to merge2 commits intocommitizen-tools:v4-9-0-test
base:v4-9-0-test
Choose a base branch
Loading
frombearomorphism:r-ask-tag-format

Conversation

bearomorphism
Copy link
Contributor

@bearomorphismbearomorphism commentedJun 10, 2025•
edited
Loading

Description

Before this change, the type oftag_format isAny | Unbounded | str at the end of the function. Actuallytag_format is defined for all code paths.

  • Ifis_correct_format isTrue, thentag_format is assigned"v$version" and the function returns it.
  • Ifis_correct_format isFalse, thentag_format is initialized in the if-block.

The function logic should be easier to understand after this change.

Checklist

@codecovCodecov
Copy link

codecovbot commentedJun 10, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Pleaseupload report for BASE (v4-9-0-test@6b4f8b0).Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@##             v4-9-0-test    #1529   +/-   ##==============================================  Coverage               ?   98.07%           ==============================================  Files                  ?       58             Lines                  ?     2700             Branches               ?        0           ==============================================  Hits                   ?     2648             Misses                 ?       52             Partials               ?        0
FlagCoverage Δ
unittests98.07% <100.00%> (?)

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lee-WLee-W added this to the4.9.0 milestoneJun 10, 2025
@bearomorphismbearomorphism marked this pull request as ready for reviewJune 10, 2025 05:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Lee-WLee-WLee-W approved these changes

@woilewoileAwaiting requested review from woilewoile is a code owner

@noirbizarrenoirbizarreAwaiting requested review from noirbizarrenoirbizarre is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

2 participants
@bearomorphism@Lee-W
[8]ページ先頭
©2009-2025 Movatter.jp