Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(bump_rule): add BumpRule, VersionIncrement, Prerelease Enum#1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bearomorphism wants to merge2 commits intocommitizen-tools:v4-9-0-test
base:v4-9-0-test
Choose a base branch
Loading
frombearomorphism:bump-rule-interface

Conversation

bearomorphism
Copy link
Contributor

Related issue:#129
Original PR:#1431

Description

Please seebump_rule.py,bump.py,cz/base.py,version_scheme.py andcommands/bump.py (~350 lines).
The rest 1000+ lines are just tests and renaming.

  • Rewrote the bump pattern matching mechanism to make the algorithm more strict and maintainable.
  • Maintained backward compatibility withCustomBumpRule.
  • Simplified code.
  • Added a new Enum classSemVerIncrement and replaceMAJOR,MINOR,PATCH with the Enum.
  • NowPrerelease is Enum.
  • Simplifyfind_increment logic inSemVerIncrement.get_highest_by_messages.
    • find_increment was the combination of 2 features: "finding the highest semantic version increment" and "parsing the semantic version increment from each git commit message".

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Runpoetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Runpoetry doc locally to ensure the documentation pages renders correctly

Expected Behavior

Steps to Test This Pull Request

Additional Context

@codecovCodecov
Copy link

codecovbot commentedJun 9, 2025
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Pleaseupload report for BASE (v4-9-0-test@6b4f8b0).Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@##             v4-9-0-test    #1518   +/-   ##==============================================  Coverage               ?   98.01%           ==============================================  Files                  ?       59             Lines                  ?     2768             Branches               ?        0           ==============================================  Hits                   ?     2713             Misses                 ?       55             Partials               ?        0
FlagCoverage Δ
unittests98.01% <100.00%> (?)

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lee-WLee-W changed the base branch frommaster tov4-9-0-testJune 10, 2025 02:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@woilewoileAwaiting requested review from woilewoile is a code owner

@Lee-WLee-WAwaiting requested review from Lee-WLee-W is a code owner

@noirbizarrenoirbizarreAwaiting requested review from noirbizarrenoirbizarre is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

2 participants
@bearomorphism@Lee-W

[8]ページ先頭

©2009-2025 Movatter.jp