Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork295
Add check against main branch hook#1400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedMay 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #1400 +/- ##==========================================+ Coverage 97.33% 97.40% +0.06%========================================== Files 42 57 +15 Lines 2104 2661 +557 ==========================================+ Hits 2048 2592 +544- Misses 56 69 +13
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| def guess_default_branch() -> str: | ||
| c = cmd.run("git branch --format '%(refname:short)' --list master main") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This makes a strong hypothesis that the reference branch can only bemaster ormain so it won't work withdevelop which is common, or any other "exotic choice".
To handle this, I usegit branch -r | grep -Po "HEAD -> .+/\K.+$" | head -n 1 which works with any default branch as long as there is a remote with a default. Thehead is for the case where there are multiple remotes, but makes the hypothesis that they share the same default branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I guess I'll have to try those commands 👀 Looks interesting!
I'm thinking of letting users setdefault_git_remote anddefault_git_branch_name (but not yet have time to impletemtn it 🥲)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, that's a good idea. Having guess the default but keeping the possibility to explicitly set it from the configuration 👍🏼
| @@ -92,7 +90,8 @@ def __call__(self): | |||
| ) | |||
| out.success("Commit validation: successful!") | |||
| def _get_commits(self): | |||
| def _get_commits(self) -> list[git.GitCommit]: | |||
| # TODO: this method seems to do a few different things. probably would be better if we could split it to smaller functions | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Already done in refactors branch
Description
Checklist
poetry alllocally to ensure this change passes linter check and testExpected behavior
Steps to Test This Pull Request
Additional context