Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test(git): add a test for handling blank with path in git commit#1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
Cliying94 wants to merge1 commit intocommitizen-tools:master
base:master
Choose a base branch
Loading
fromCliying94:#572-LYC

Conversation

Cliying94
Copy link

related:#572

Description

add-a-test-for-handling-blank-with-path-in-git-commit

  • mock action:
    Whether the path includes blank or not, the git commit action can parse anyway and correctly executecommit under commitizen/commitizen/git.py and go through the util functioncreate_file_and_commit

Checklist

  • Add test cases to all the changes you introduce
  • Run./scripts/format and./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

if the project path is including blank, the program should work.

Steps to Test This Pull Request

run./scripts/test or run the single texttest_git_commit_command_with_varied_paths_handles_blank undertests/test_git.py

@codecovCodecov
Copy link

codecovbot commentedMar 30, 2024
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base(120d514) to head(ef51f24).
Report is 254 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@##           master    #1044      +/-   ##==========================================+ Coverage   97.33%   97.48%   +0.15%==========================================  Files          42       55      +13       Lines        2104     2429     +325     ==========================================+ Hits         2048     2368     +320- Misses         56       61       +5
FlagCoverage Δ
unittests97.48% <ø> (+0.15%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@woilewoileAwaiting requested review from woilewoile is a code owner

@Lee-WLee-WAwaiting requested review from Lee-WLee-W is a code owner

@noirbizarrenoirbizarreAwaiting requested review from noirbizarrenoirbizarre is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Cliying94@Lee-W

[8]ページ先頭

©2009-2025 Movatter.jp