NotificationsYou must be signed in to change notification settings
Fork10.2k
Star90.8k

[V3] convert nodes_lora_extract.py to V3 schema#10182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Kosinkadink merged 1 commit intocomfyanonymous:masterfrombigcat88:v3/nodes_lora_extract

Oct 9, 2025

Merged

[V3] convert nodes_lora_extract.py to V3 schema#10182

Kosinkadink merged 1 commit intocomfyanonymous:masterfrombigcat88:v3/nodes_lora_extract

Oct 9, 2025

Conversation

Copy link

Contributor

bigcat88 commentedOct 3, 2025•
edited
Loading

Node was tested after conversion:

Git diff:

diff --git a/v3_object_info.json b/master_object_info.jsonindex 3e97d5a..1e69296 100644--- a/v3_object_info.json+++ b/master_object_info.json@@ -20742,8 +20742,7 @@                 "filename_prefix": [                     "STRING",                     {-                        "default": "loras/ComfyUI_extracted_lora",-                        "multiline": false+                        "default": "loras/ComfyUI_extracted_lora"                     }                 ],                 "rank": [@@ -20756,14 +20755,10 @@                     }                 ],                 "lora_type": [-                    "COMBO",-                    {-                        "multiselect": false,-                        "options": [-                            "standard",-                            "full_diff"-                        ]-                    }+                    [+                        "standard",+                        "full_diff"+                    ]                 ],                 "bias_diff": [                     "BOOLEAN",@@ -20785,14 +20780,6 @@                         "tooltip": "The CLIPSubtract output to be converted to a lora."                     }                 ]-            },-            "hidden": {-                "prompt": [-                    "PROMPT"-                ],-                "extra_pnginfo": [-                    "EXTRA_PNGINFO"-                ]             }         },         "input_order": {@@ -20805,25 +20792,17 @@             "optional": [                 "model_diff",                 "text_encoder_diff"-            ],-            "hidden": [-                "prompt",-                "extra_pnginfo"             ]         },         "output": [],         "output_is_list": [],         "output_name": [],-        "output_tooltips": [],         "name": "LoraSave",         "display_name": "Extract and Save Lora",         "description": "",         "python_module": "comfy_extras.nodes_lora_extract",         "category": "_for_testing",-        "output_node": true,-        "deprecated": false,-        "experimental": true,-        "api_node": false+        "output_node": true     },     "TorchCompileModel": {         "input": {

note: node doesn't usemetadata - difference inPROMPT andEXTRA_PNGINFO should be ok?