- Notifications
You must be signed in to change notification settings - Fork0
added shared folder#123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
d83570b to1fb9150Comparebd18a47 toe6618a8Compare
sjaghori left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we need eslint rules ('import/no-restricted-paths' package e.g.) to keep things separat:
TODO's:
- prevents imports from src/* into services/*
- prevents imports from src/* into shared/*
- prevents imports from services/* into shared/*
vite.config.ts Outdated
| include:['src/**/*.{test,spec}.{js,ts}','services/**/*.{test,spec}.{js,ts}'] | ||
| }, | ||
| server:{port:3000,fs:{allow:['services/src/util/slug']}},// Add shared workspace and move slug to shared | ||
| server:{port:3000,fs:{allow:['shared/src']}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
a general question, do we want to have a src folder inside shared workspace? Just saying that we don't have to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it we could get rid of the src folder.
0510a72 toe2b0434Comparee6618a8 toa3ce1f4Comparea3ce1f4 to9a978f9CompareSigned-off-by: Benjamin Strasser <bp.strasser@gmail.com>
…s not supported by pnpm, fixes ci, updates pnpm, vitest & vite
No description provided.