- Notifications
You must be signed in to change notification settings - Fork2.4k
feat: support tailwind.css external resourses for Sandpack#8647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
theshadowagent wants to merge1 commit intocodesandbox:masterChoose a base branch fromrorkai:feat/tailwindcss-external-styles
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
feat: support tailwind.css external resourses for Sandpack#8647
theshadowagent wants to merge1 commit intocodesandbox:masterfromrorkai:feat/tailwindcss-external-styles
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch inWeb Editor •VS Code •Insiders |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Complete Tailwind CSS Play CDN support in Sandpack Bundler
What kind of change does this PR introduce?
Adds complete support for Tailwind CSS Play CDN in Sandpack by properly handling custom Tailwind CSS configs.
What is the current behavior?
Currently, when importing Tailwind Play CDN via
externalResources
in Sandpack it is impossible to customize Tailwindglobals.css
config because Sandpack bundler doesn't set the expectedtype="text/tailwindcss"
attribute of the<style>/
` tags. This prevents the Tailwind Play CDN (https://cdn.tailwindcss.com) from compiling CSS with custom Tailwind config.What is the new behavior?
The Sandbox bundler now correctly identifies Tailwind CSS external resourses and sets the expected
type="text/tailwindcss"
attribute when the external resource file name includes'tailwind.css'
.This enables:
globals.tailwind.css
viaexternalResources
tailwind.config.js
viaexternalResources
Steps to test
https://cdn.tailwindcss.com
in Sandpack'sexternalResources
tailwind.config.js
file to Sandpack'sexternalResources
globals.tailwind.css
to Sandpack'sexternalResources
with custom TailwindCSS styles (same asglobals.css
in standard Tailwind projects)Checklist
Additional Context
This feature is for developers who want to use Tailwind CSS in Sandpack with custom
tailwind.config.js
and customglobals.css
. The Tailwind Play CDN requirestype="text/tailwindcss"
in<link>/<style>
tags to support customglobals.css
files, which this PR now supports.Tailwind CDN docs:https://tailwindcss.com/docs/installation/play-cdn