Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Nov 8, 2022. It is now read-only.

refactor(article-upvote): use common upvote module#333

Merged
mydearxym merged 49 commits intodevfromcommon-upvote
May 5, 2021

Conversation

mydearxym
Copy link
Member

@mydearxymmydearxym commentedApr 30, 2021
edited
Loading

  • remove FavoriteXXX
  • remove StarXXX
  • use common upvote/collect to handle
  • rewrite whole CollectFolder logic to replace old FavoriteCategories
  • add new meta to collect folder
  • use macro to refactor
  • refactor codebar and related test units

@codecov
Copy link

codecovbot commentedMay 5, 2021

Codecov Report

Merging#333 (38e8480) intodev (d38603f) willdecrease coverage by0.26%.
The diff coverage is92.53%.

Impacted file tree graph

@@            Coverage Diff             @@##              dev     #333      +/-   ##==========================================- Coverage   87.15%   86.88%   -0.27%==========================================  Files         107      101       -6       Lines        1331     1304      -27     ==========================================- Hits         1160     1133      -27  Misses        171      171
Impacted FilesCoverage Δ
lib/groupher_server/accounts/achievement.ex100.00% <ø> (ø)
lib/groupher_server/accounts/delegates/fans.ex100.00% <ø> (ø)
lib/groupher_server/accounts/user.ex100.00% <ø> (ø)
lib/groupher_server/accounts/utils/loader.ex100.00% <ø> (ø)
lib/groupher_server/application.ex75.00% <ø> (ø)
lib/groupher_server/cms/community.ex100.00% <ø> (ø)
lib/groupher_server/cms/delegates/article_curd.ex100.00% <ø> (ø)
lib/groupher_server/cms/post.ex100.00% <ø> (ø)
lib/groupher_server/cms/repo.ex100.00% <ø> (ø)
lib/groupher_server/cms/utils/matcher.ex40.00% <ø> (ø)
... and26 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updated38603f...38e8480. Read thecomment docs.

@mydearxymmydearxym merged commit3b35013 intodevMay 5, 2021
@mydearxymmydearxym deleted the common-upvote branchMay 5, 2021 07:28
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mydearxym

[8]ページ先頭

©2009-2025 Movatter.jp