Commitca57175

committed

fix(community): remove editors subscribers in community fields

1 parent9f50d45 commitca57175Copy full SHA for ca57175

File tree

-19

lines changed

lib
- groupher_server_web/schema/cms
  - cms_types.ex
- groupher_server/cms/delegates
  - community_operation.ex
test/groupher_server_web/query/cms
- cms_test.exs

-19

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -307,6 +307,10 @@ defmodule GroupherServer.CMS.Delegate.CommunityOperation do`
`307`	`307`	`Map.merge(geo_info,%{"value"=>max(geo_info["value"]-1,0)})`
`308`	`308`	`end`
`309`	`309`
	`310`	`+defpresult({:ok,%{subscribed_community:result}})do`
	`311`	`+{:ok,result}`
	`312`	`+end`
	`313`	`+`
`310`	`314`	`defpresult({:ok,%{update_editors_count:result}})do`
`311`	`315`	`{:ok,result}`
`312`	`316`	`end`

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -267,12 +267,6 @@ defmodule GroupherServerWeb.Schema.CMS.Types do`
`267`	`267`	`field(:subscribers_count,:integer)`
`268`	`268`	`field(:editors_count,:integer)`
`269`	`269`
`270`		`-field:subscribers,list_of(:user)do`
`271`		`-arg(:filter,:members_filter)`
`272`		`-middleware(M.PageSizeProof)`
`273`		`-resolve(dataloader(CMS,:subscribers))`
`274`		`-end`
`275`		`-`
`276`	`270`	`field:editors,list_of(:user)do`
`277`	`271`	`arg(:filter,:members_filter)`
`278`	`272`	`middleware(M.PageSizeProof)`

Lines changed: 2 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -381,14 +381,11 @@ defmodule GroupherServer.Test.Query.CMS.Basic do`
`381`	`381`	`community(id: $id) {`
`382`	`382`	`id`
`383`	`383`	`subscribersCount`
`384`		`- subscribers {`
`385`		`- id`
`386`		`- nickname`
`387`		`- }`
`388`	`384`	`}`
`389`	`385`	`}`
`390`	`386`	`"""`
`391`		`-test"guest can get subscribers list and count of a community",~m(guest_conn community)ado`
	`387`	`+@tag:wip2`
	`388`	`+test"guest can get subscribers count of a community",~m(guest_conn community)ado`
`392`	`389`	`{:ok,users}=db_insert_multi(:user,assert_v(:inner_page_size))`
`393`	`390`
`394`	`391`	`Enum.each(`
`@@ -398,16 +395,8 @@ defmodule GroupherServer.Test.Query.CMS.Basic do`
`398`	`395`
`399`	`396`	`variables=%{id:community.id}`
`400`	`397`	`results=guest_conn\|>query_result(@query,variables,"community")`
`401`		`-subscribers=results["subscribers"]`
`402`	`398`	`subscribers_count=results["subscribersCount"]`
`403`	`399`
`404`		`-[user_1,user_2,user_3,user_x]=users\|>firstn_and_last(3)`
`405`		`-`
`406`		`-assertresults["id"]==to_string(community.id)`
`407`		`-assertsubscribers\|>Enum.any?(&(&1["id"]==to_string(user_1.id)))`
`408`		`-assertsubscribers\|>Enum.any?(&(&1["id"]==to_string(user_2.id)))`
`409`		`-assertsubscribers\|>Enum.any?(&(&1["id"]==to_string(user_3.id)))`
`410`		`-assertsubscribers\|>Enum.any?(&(&1["id"]==to_string(user_x.id)))`
`411`	`400`	`assertsubscribers_count==assert_v(:inner_page_size)`
`412`	`401`	`end`
`413`	`402`

Comments

(0)