Commitbea44ab

committed

fix(community): meta nil edge-case

1 parentaf3bfc2 commitbea44abCopy full SHA for bea44ab

File tree

-10

lines changed

-10

lines changed

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -48,10 +48,12 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do`
`48`	`48`	`update_viewed_user_list(article,user_id)`
`49`	`49`	`end)`
`50`	`50`	`\|>Multi.run(:set_viewer_has_states,fn_,%{inc_views:article}->`
	`51`	`+article_meta=ifis_nil(article.meta),do:@default_article_meta,else:article.meta`
	`52`	`+`
`51`	`53`	`viewer_has_states=%{`
`52`		`-viewer_has_collected:user_idinarticle.meta.collected_user_ids,`
`53`		`-viewer_has_upvoted:user_idinarticle.meta.upvoted_user_ids,`
`54`		`-viewer_has_reported:user_idinarticle.meta.reported_user_ids`
	`54`	`+viewer_has_collected:user_idinarticle_meta.collected_user_ids,`
	`55`	`+viewer_has_upvoted:user_idinarticle_meta.upvoted_user_ids,`
	`56`	`+viewer_has_reported:user_idinarticle_meta.reported_user_ids`
`55`	`57`	`}`
`56`	`58`
`57`	`59`	`{:ok,Map.merge(article,viewer_has_states)}`

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@ defmodule GroupherServer.Test.CMS.Community do`
`17`	`17`	`end`
`18`	`18`
`19`	`19`	`describe"[cms community read]"do`
`20`		`-@tag:wip2`
`21`	`20`	`test"read community should inc views",~m(community)ado`
`22`	`21`	`{:ok,community}=CMS.read_community(%{id:community.id})`
`23`	`22`
`@@ -28,7 +27,6 @@ defmodule GroupherServer.Test.CMS.Community do`
`28`	`27`	`assertcommunity.views==3`
`29`	`28`	`end`
`30`	`29`
`31`		`-@tag:wip2`
`32`	`30`	`test"read subscribed community should have a flag",~m(community user user2)ado`
`33`	`31`	`{:ok,_}=CMS.subscribe_community(community,user)`
`34`	`32`
`@@ -50,19 +48,17 @@ defmodule GroupherServer.Test.CMS.Community do`
`50`	`48`	`assertcommunity.id==record.id`
`51`	`49`	`end`
`52`	`50`
`53`		`-@tag:wip2`
`54`	`51`	`test"user subscribe a community will update the community's subscribted info",`
`55`	`52`	`~m(user community)ado`
`56`	`53`	`assertcommunity.subscribers_count==0`
`57`		`-{:ok,record}=CMS.subscribe_community(community,user)`
	`54`	`+{:ok,_record}=CMS.subscribe_community(community,user)`
`58`	`55`
`59`	`56`	`{:ok,community}=ORM.find(Community,community.id)`
`60`	`57`	`assertcommunity.subscribers_count==1`
`61`	`58`
`62`	`59`	`assertuser.idincommunity.meta.subscribed_user_ids`
`63`	`60`	`end`
`64`	`61`
`65`		`-@tag:wip2`
`66`	`62`	`test"user unsubscribe a community will update the community's subscribted info",`
`67`	`63`	`~m(user community)ado`
`68`	`64`	`{:ok,_}=CMS.subscribe_community(community,user)`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ defmodule GroupherServer.Test.Query.Articles.Job do`
`19`	`19`	`}`
`20`	`20`	`}`
`21`	`21`	`"""`
`22`		`-`
	`22`	`+@tag:wip3`
`23`	`23`	`test"basic graphql query on job with logined user",~m(user_conn job)ado`
`24`	`24`	`variables=%{id:job.id}`
`25`	`25`	`results=user_conn\|>query_result(@query,variables,"job")`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ defmodule GroupherServer.Test.Query.Articles.Repo do`
`19`	`19`	`}`
`20`	`20`	`}`
`21`	`21`	`"""`
`22`		`-`
	`22`	`+@tag:wip2`
`23`	`23`	`test"basic graphql query on repo with logined user",~m(user_conn repo)ado`
`24`	`24`	`variables=%{id:repo.id}`
`25`	`25`	`results=user_conn\|>query_result(@query,variables,"repo")`

Comments

(0)