Commitb4a3abf

committed

fix(commentsParticipators): tmp fix for issue#16

1 parentc8bc3f2 commitb4a3abfCopy full SHA for b4a3abf

File tree

+10

-3

lines changed

lib
- groupher_server_web/middleware
  - cut_participators.ex
- groupher_server/cms/utils
  - loader.ex

+10

-3

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,9 @@ defmodule GroupherServer.CMS.Utils.Loader do`
`181`	`181`	`defquery({"posts_comments",PostComment},%{filter:filter,unique:true})do`
`182`	`182`	`PostComment`
`183`	`183`	`\|>join(:inner,[c],ainassoc(c,:author))`
`184`		`-\|>distinct([c,a],a.id)`
	`184`	`+# NOTE: this distinct not working in production env, so the uniq logic is move to`
	`185`	`+# cut_participators.ex middleware, when the data is large, will cause performace issue`
	`186`	`+# \|> distinct([c, a], a.id)`
`185`	`187`	`\|>select([c,a],a)`
`186`	`188`
`187`	`189`	`# \|> select([c, a], %{`

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,8 @@ defmodule GroupherServerWeb.Middleware.CutParticipators do`
`8`	`8`	`# should use WINDOW function`
`9`	`9`	`# see https://github.com/coderplanets/coderplanets_server/issues/16`
`10`	`10`	`#`
	`11`	`+ # the Enum.uniq logic is a tmp sulution for distinct comments users, this should be`
	`12`	`+ # in dataloader logic, but the distinct is not working in production env`
`11`	`13`	`"""`
`12`	`14`
`13`	`15`	`@behaviourAbsinthe.Middleware`
`@@ -16,11 +18,14 @@ defmodule GroupherServerWeb.Middleware.CutParticipators do`
`16`	`18`	`defcall(%{errors:errors}=resolution,_)whenlength(errors)>0,do:resolution`
`17`	`19`
`18`	`20`	`defcall(%{value:value,arguments:%{filter:%{first:first}}=args}=resolution,_)do`
`19`		`-%{resolution\|value:value\|>Enum.reverse()\|>Enum.slice(0,first)}`
	`21`	`+%{resolution\|value:value\|>Enum.uniq()\|>Enum.reverse()\|>Enum.slice(0,first)}`
`20`	`22`	`end`
`21`	`23`
`22`	`24`	`defcall(%{value:value}=resolution,_)do`
`23`		`-%{resolution\|value:value\|>Enum.reverse()\|>Enum.slice(0,@default_length)}`
	`25`	`+%{`
	`26`	`+resolution`
	`27`	`+\|value:value\|>Enum.uniq()\|>Enum.reverse()\|>Enum.slice(0,@default_length)`
	`28`	`+}`
`24`	`29`	`end`
`25`	`30`
`26`	`31`	`defcall(resolution,_),do:resolution`

Comments

(0)