Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Nov 8, 2022. It is now read-only.

Commit5129ae6

Browse files
committed
refactor(article): rm metric module, add class module
1 parentf572573 commit5129ae6

File tree

13 files changed

+27
-31
lines changed

13 files changed

+27
-31
lines changed

‎lib/helper/metric/article.ex‎renamed to ‎lib/helper/converter/editor_to_html/class.ex‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
defmoduleHelper.Metric.Articledo
1+
defmoduleHelper.Converter.EditorToHTML.Classdo
22
@moduledoc"""
33
html article class names parsed from editor.js's json data
44
@@ -9,7 +9,7 @@ defmodule Helper.Metric.Article do
99
@doc"""
1010
get all the class names of the parsed editor.js's html parts
1111
"""
12-
defclass_names(:html)do
12+
defarticle()do
1313
%{
1414
# root wrapper
1515
"viewer"=>"article-viewer-wrapper",

‎lib/helper/converter/editor_to_html/frags/header.ex‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,11 @@ defmodule Helper.Converter.EditorToHTML.Frags.Header do
44
55
see https://editorjs.io/
66
"""
7-
aliasHelper.Metric
87
aliasHelper.Types,as:T
98

10-
@classget_in(Metric.Article.class_names(:html),["header"])
9+
aliasHelper.Converter.EditorToHTML.Class
10+
11+
@classget_in(Class.article(),["header"])
1112

1213
@specget(T.editor_header())::T.html()
1314
defget(%{"eyebrowTitle"=>eyebrow_title,"footerTitle"=>footer_title}=data)do

‎lib/helper/converter/editor_to_html/frags/list.ex‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ defmodule Helper.Converter.EditorToHTML.Frags.List do
44
55
see https://editorjs.io/
66
"""
7-
aliasHelper.Metric
7+
aliasHelper.Converter.EditorToHTML.Class
88

9-
@classget_in(Metric.Article.class_names(:html),["list"])
9+
@classget_in(Class.article(),["list"])
1010

1111
defget_item(:checklist,%{
1212
"checked"=>checked,

‎lib/helper/converter/editor_to_html/header.ex‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,9 @@ defmodule Helper.Converter.EditorToHTML.Header do
99

1010
defmacro__using__(_opts)do
1111
quotedo
12-
aliasHelper.Metric
13-
aliasHelper.Converter.EditorToHTML.Frags
12+
aliasHelper.Converter.EditorToHTML.{Class,Frags}
1413

15-
@classget_in(Metric.Article.class_names(:html),["header"])
14+
@classget_in(Class.article(),["header"])
1615

1716
defpparse_block(%{"type"=>"header","data"=>data})do
1817
Frags.Header.get(data)

‎lib/helper/converter/editor_to_html/index.ex‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,16 @@ defmodule Helper.Converter.EditorToHTML do
1313
"""
1414

1515
useHelper.Converter.EditorToHTML.{Header,Paragraph,List}
16+
aliasHelper.Types,as:T
1617

17-
aliasHelper.{Metric,Utils}
18+
aliasHelper.Utils
1819
aliasHelper.Converter.{EditorToHTML,HtmlSanitizer}
19-
aliasEditorToHTML.Validator
20+
aliasEditorToHTML.{Class,Validator}
2021

2122
# alias EditorToHTML.Assets.{DelimiterIcons}
23+
@root_classClass.article()
2224

23-
@root_classMetric.Article.class_names(:html)
24-
25-
@specto_html(binary|maybe_improper_list)::false|{:ok,<<_::64,_::_*8>>}
25+
@specto_html(String.t())::T.ok_html()
2626
defto_html(string)whenis_binary(string)do
2727
with{:ok,parsed}=string_to_json(string),
2828
{:ok,_}<-Validator.is_valid(parsed)do

‎lib/helper/converter/editor_to_html/list.ex‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,9 @@ defmodule Helper.Converter.EditorToHTML.List do
99

1010
defmacro__using__(_opts)do
1111
quotedo
12-
aliasHelper.Metric
13-
aliasHelper.Converter.EditorToHTML.Frags
12+
aliasHelper.Converter.EditorToHTML.{Class,Frags}
1413

15-
# @class get_in(Metric.Article.class_names(:html), "list")
14+
# @class get_in(Class.article(),["list"])
1615

1716
defpparse_block(%{"type"=>"list","data"=>data})do
1817
%{"items"=>items}=data

‎lib/helper/converter/editor_to_html/paragraph.ex‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ defmodule Helper.Converter.EditorToHTML.Paragraph do
66
"""
77
defmacro__using__(_opts)do
88
quotedo
9-
# alias Helper.Metric
10-
119
defpparse_block(%{"type"=>"paragraph","data"=>%{"text"=>text}})do
1210
"<p>#{text}</p>"
1311
end

‎lib/helper/types.ex‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,5 @@ defmodule Helper.Types do
4242
html fragment
4343
"""
4444
@typehtml::String.t()
45+
@typeok_html::{:ok,String.t()}
4546
end

‎test/helper/converter/editor_to_html_test/header_test.exs‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,10 @@ defmodule GroupherServer.Test.Helper.Converter.EditorToHTML.Header do
33

44
useGroupherServerWeb.ConnCase,async:true
55

6-
aliasHelper.Metric
76
aliasHelper.Converter.EditorToHTML,as:Parser
8-
aliasHelper.Converter.EditorToHTML.Frags
7+
aliasHelper.Converter.EditorToHTML.{Class,Frags}
98

10-
@root_classMetric.Article.class_names(:html)
9+
@root_classClass.article()
1110

1211
describe"[header block unit]"do
1312
@editor_json%{

‎test/helper/converter/editor_to_html_test/index_test.exs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@ defmodule GroupherServer.Test.Helper.Converter.EditorToHTML do
33

44
useGroupherServerWeb.ConnCase,async:true
55

6-
aliasHelper.Metric
6+
aliasHelper.Converter.EditorToHTML.Class
77
aliasHelper.Converter.EditorToHTML,as:Parser
88

99
# "<addr class="cdx-lock">hello</addr> Editor.js <mark class="cdx-marker">workspace</mark>. is an element &lt;script&gt;alert("hello")&lt;/script&gt;"
1010

1111
# "text" : "<script>evil scripts</script>"
12-
@root_classMetric.Article.class_names(:html)
12+
@root_classClass.article()
1313

1414
@real_editor_data~S({
1515
"time" : 1567250876713,

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp