Commit4eac5ff

committed

refactor(article-comments): helper for raise custom error

1 parentfee3ed7 commit4eac5ffCopy full SHA for 4eac5ff

File tree

+14

-4

lines changed

lib
- groupher_server/cms/delegates
  - article_comment.ex
- helper
  - error_code.ex
test
- groupher_server_web/query/cms
  - article_comment_test.exs
- groupher_server/cms
  - article_comment_test.exs

+14

-4

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do`
`4`	`4`	`"""`
`5`	`5`	`importEcto.Query,warn:false`
`6`	`6`	`importHelper.Utils,only:[done:1]`
	`7`	`+importHelper.ErrorCode`
`7`	`8`
`8`	`9`	`importGroupherServer.CMS.Utils.Matcher2`
`9`	`10`	`importShortMaps`
`@@ -682,8 +683,8 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do`
`682`	`683`	`defpupsert_comment_result({:ok,%{update_comment_flag:result}}),do:{:ok,result}`
`683`	`684`	`defpupsert_comment_result({:ok,%{delete_article_comment:result}}),do:{:ok,result}`
`684`	`685`
`685`		`-defpupsert_comment_result({:error,:create_comment,result,_steps})do`
`686`		`-{:error,result}`
	`686`	`+defpupsert_comment_result({:error,:create_article_comment,result,_steps})do`
	`687`	`+raise_error(:create_comment,result)`
`687`	`688`	`end`
`688`	`689`
`689`	`690`	`defpupsert_comment_result({:error,:add_participator,result,_steps})do`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,12 @@ defmodule Helper.ErrorCode do`
`6`	`6`	`@changeset_base4100`
`7`	`7`	`@throttle_base4200`
`8`	`8`	`@account_base4300`
	`9`	`+@comment_base4400`
	`10`	`+`
	`11`	`+@specraise_error(Atom.t(),String.t())::{:error,[message:String.t(),code:Integer.t()]}`
	`12`	`+defraise_error(code_atom,msg)do`
	`13`	`+{:error,[message:msg,code:ecode(code_atom)]}`
	`14`	`+end`
`9`	`15`
`10`	`16`	`# account error code`
`11`	`17`	`defecode(:account_login),do:@account_base+1`
`@@ -32,6 +38,9 @@ defmodule Helper.ErrorCode do`
`32`	`38`	`defecode(:throttle_inverval),do:@throttle_base+1`
`33`	`39`	`defecode(:throttle_hour),do:@throttle_base+2`
`34`	`40`	`defecode(:throttle_day),do:@throttle_base+3`
	`41`	`+#`
	`42`	`+defecode(:create_comment),do:@comment_base+1`
	`43`	`+`
`35`	`44`	`defecode,do:@default_base`
`36`	`45`	`# def ecode(_), do: @default_base`
`37`	`46`	`end`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -318,7 +318,7 @@ defmodule GroupherServer.Test.CMS.ArticleComment do`
`318`	`318`	`end`
`319`	`319`
`320`	`320`	`describe"paged article comments"do`
`321`		`-@tag:wip2`
	`321`	`+@tag:wip`
`322`	`322`	`test"can load paged comments participators of a article",~m(user post)ado`
`323`	`323`	`total_count=30`
`324`	`324`	`page_number=1`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -509,7 +509,7 @@ defmodule GroupherServer.Test.Query.ArticleComment do`
`509`	`509`	`}`
`510`	`510`	`}`
`511`	`511`	`"""`
`512`		`-@tag:wip2`
	`512`	`+@tag:wip`
`513`	`513`	`test"guest user can get paged participators",~m(guest_conn post user)ado`
`514`	`514`	`total_count=30`
`515`	`515`	`page_size=10`

Comments

(0)