Commit4664fd1

committed

refactor(pagi): cleanup & naming adjust

1 parent825c9f3 commit4664fd1Copy full SHA for 4664fd1

File tree

-4

lines changed

lib
- groupher_server/accounts/delegates
  - collect_folder.ex
- helper
  - orm.ex
test/helper
- orm_test.exs

-4

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ defmodule GroupherServer.Accounts.Delegate.CollectFolder do`
`82`	`82`	`end)`
`83`	`83`
`84`	`84`	`Repo.preload(folder.collects,article_preload)`
`85`		`-\|>ORM.embeds_paginater(filter)`
	`85`	`+\|>ORM.embeds_paginator(filter)`
`86`	`86`	`\|>ORM.extract_articles()`
`87`	`87`	`\|>done()`
`88`	`88`	`end`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ defmodule Helper.ORM do`
`29`	`29`
`30`	`30`	`# NOTE: should have limit length for list, otherwise it will cause mem issues`
`31`	`31`	`@doc"simu paginator in normal list, used for embeds_many etc"`
`32`		`-defembeds_paginater(list,%{page:page,size:size}=_filter)whenis_list(list)do`
	`32`	`+defembeds_paginator(list,%{page:page,size:size}=_filter)whenis_list(list)do`
`33`	`33`	`chunked_list=Enum.chunk_every(list,size)`
`34`	`34`
`35`	`35`	`entries=chunked_list\|>Enum.at(page-1)`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ defmodule GroupherServer.Test.Helper.ORM do`
`75`	`75`	`end)`
`76`	`76`
`77`	`77`	`filter=%{page:1,size:30}`
`78`		`-result=ORM.embeds_paginater(list,filter)`
	`78`	`+result=ORM.embeds_paginator(list,filter)`
`79`	`79`
`80`	`80`	`assertresult\|>is_valid_pagination?(:raw)`
`81`	`81`	`assertresult.total_count==length(list)`
`@@ -85,7 +85,7 @@ defmodule GroupherServer.Test.Helper.ORM do`
`85`	`85`	`assertresult.entries\|>List.last()=="i-30"`
`86`	`86`
`87`	`87`	`filter=%{page:4,size:30}`
`88`		`-result=ORM.embeds_paginater(list,filter)`
	`88`	`+result=ORM.embeds_paginator(list,filter)`
`89`	`89`
`90`	`90`	`assertresult.page_number==4`
`91`	`91`	`assertresult.entries\|>List.first()=="i-91"`

Comments

(0)