Commit007958d

committed

fix(article-editor): update edege case

1 parent82400fe commit007958dCopy full SHA for 007958d

File tree

+12

-3

lines changed

+12

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommunity do`
`129`	`129`
`130`	`130`	`@doc"update isEdited meta label if needed"`
`131`	`131`	`# TODO: diff history`
`132`		`-defupdate_edit_status(%{meta:%Embeds.ArticleMeta{is_edited:false}=meta}=content)do`
	`132`	`+defupdate_edit_status(%{meta:%Embeds.ArticleMeta{is_edited:_}=meta}=content)do`
`133`	`133`	`meta=meta\|>strip_struct\|>Map.merge(%{is_edited:true})`
`134`	`134`	`ORM.update_meta(content,meta)`
`135`	`135`	`end`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -278,7 +278,8 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do`
`278`	`278`	`end`
`279`	`279`	`end)`
`280`	`280`	`\|>Multi.run(:update_edit_status,fn_,%{update_article:update_article}->`
`281`		`-ArticleCommunity.update_edit_status(update_article)`
	`281`	`+IO.inspect(update_article,label:"## -3")`
	`282`	`+ArticleCommunity.update_edit_status(update_article)\|>IO.inspect(label:"## 2")`
`282`	`283`	`end)`
`283`	`284`	`\|>Multi.run(:after_hooks,fn_,%{update_article:update_article}->`
`284`	`285`	`Later.run({Hooks.Cite,:handle,[update_article]})`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,8 @@ defmodule GroupherServerWeb.Schema.CMS.Types do`
`60`	`60`	`general_article_fields()`
`61`	`61`	`comments_fields()`
`62`	`62`
	`63`	`+field(:is_question,:boolean)`
	`64`	`+`
`63`	`65`	`timestamp_fields(:article)`
`64`	`66`	`end`
`65`	`67`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Post do`
`16`	`16`	`arg(:community_id,non_null(:id))`
`17`	`17`	`arg(:thread,:thread,default_value::post)`
`18`	`18`	`arg(:article_tags,list_of(:id))`
	`19`	`+arg(:is_question,:boolean)`
`19`	`20`
`20`	`21`	`middleware(M.Authorize,:login)`
`21`	`22`	`# middleware(M.PublishThrottle)`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -27,15 +27,18 @@ defmodule GroupherServer.Test.Mutation.Articles.Post do`
`27`	`27`	`$body: String!`
`28`	`28`	`$communityId: ID!`
`29`	`29`	`$articleTags: [Id]`
	`30`	`+ $linkAddr: String`
`30`	`31`	`) {`
`31`	`32`	`createPost(`
`32`	`33`	`title: $title`
`33`	`34`	`body: $body`
`34`	`35`	`communityId: $communityId`
`35`	`36`	`articleTags: $articleTags`
	`37`	`+ linkAddr: $linkAddr`
`36`	`38`	`) {`
`37`	`39`	`id`
`38`	`40`	`title`
	`41`	`+ linkAddr`
`39`	`42`	`document {`
`40`	`43`	`bodyHtml`
`41`	`44`	`}`
`@@ -45,19 +48,21 @@ defmodule GroupherServer.Test.Mutation.Articles.Post do`
`45`	`48`	`}`
`46`	`49`	`}`
`47`	`50`	`"""`
	`51`	`+@tag:wip`
`48`	`52`	`test"create post with valid attrs and make sure author exsit"do`
`49`	`53`	`{:ok,user}=db_insert(:user)`
`50`	`54`	`user_conn=simu_conn(:user,user)`
`51`	`55`
`52`	`56`	`{:ok,community}=db_insert(:community)`
`53`		`-post_attr=mock_attrs(:post)`
	`57`	`+post_attr=mock_attrs(:post)\|>Map.merge(%{linkAddr:"https://helloworld"})`
`54`	`58`
`55`	`59`	`variables=post_attr\|>Map.merge(%{communityId:community.id})`
`56`	`60`	`created=user_conn\|>mutation_result(@create_post_query,variables,"createPost")`
`57`	`61`	`{:ok,post}=ORM.find(Post,created["id"])`
`58`	`62`
`59`	`63`	`assertcreated["id"]==to_string(post.id)`
`60`	`64`	`assertcreated["originalCommunity"]["id"]==to_string(community.id)`
	`65`	`+assertcreated["linkAddr"]=="https://helloworld"`
`61`	`66`
`62`	`67`	`assert{:ok,_}=ORM.find_by(Author,user_id:user.id)`
`63`	`68`	`end`

Comments

(0)