- Notifications
You must be signed in to change notification settings - Fork38
fix: converting stories#599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
SavvyShah wants to merge8 commits intocoderoad:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes fromall commits
Commits
Show all changes
8 commits Select commitHold shift + click to select a range
276b695 get storybook to build again in a webpack 5 world
ShMcKcb54ae5 migrate storybook to use main.ts
ShMcK4b5123a setup a single storybook story
ShMcKa085c33 feat: first useful story
SavvyShah40acd29 chore: update packages
SavvyShah8424626 fix: correct configuration
SavvyShah975ca1e feat: sass to node-sass
SavvyShah4d94327 Merge branch 'master' into fix/storybook
SavvyShahFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
67 changes: 67 additions & 0 deletionsweb-app/.babelrc.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| { | ||
| "sourceType": "unambiguous", | ||
| "presets": [ | ||
| [ | ||
| "@babel/preset-env", | ||
| { | ||
| "shippedProposals": true, | ||
| "loose": true | ||
| } | ||
| ], | ||
| "@babel/preset-typescript" | ||
| ], | ||
| "plugins": [ | ||
| "@babel/plugin-transform-shorthand-properties", | ||
| "@babel/plugin-transform-block-scoping", | ||
| [ | ||
| "@babel/plugin-proposal-decorators", | ||
| { | ||
| "legacy": true | ||
| } | ||
| ], | ||
| [ | ||
| "@babel/plugin-proposal-class-properties", | ||
| { | ||
| "loose": true | ||
| } | ||
| ], | ||
| [ | ||
| "@babel/plugin-proposal-private-property-in-object", | ||
| { | ||
| "loose": true | ||
| } | ||
| ], | ||
| [ | ||
| "@babel/plugin-proposal-private-methods", | ||
| { | ||
| "loose": true | ||
| } | ||
| ], | ||
| "@babel/plugin-proposal-export-default-from", | ||
| "@babel/plugin-syntax-dynamic-import", | ||
| [ | ||
| "@babel/plugin-proposal-object-rest-spread", | ||
| { | ||
| "loose": true, | ||
| "useBuiltIns": true | ||
| } | ||
| ], | ||
| "@babel/plugin-transform-classes", | ||
| "@babel/plugin-transform-arrow-functions", | ||
| "@babel/plugin-transform-parameters", | ||
| "@babel/plugin-transform-destructuring", | ||
| "@babel/plugin-transform-spread", | ||
| "@babel/plugin-transform-for-of", | ||
| "babel-plugin-macros", | ||
| "@babel/plugin-proposal-optional-chaining", | ||
| "@babel/plugin-proposal-nullish-coalescing-operator", | ||
| [ | ||
| "babel-plugin-polyfill-corejs3", | ||
| { | ||
| "method": "usage-global", | ||
| "absoluteImports": "core-js", | ||
| "version": "3.21.1" | ||
| } | ||
| ] | ||
| ] | ||
| } |
3 changes: 0 additions & 3 deletionsweb-app/.storybook/addons.ts
This file was deleted.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
19 changes: 0 additions & 19 deletionsweb-app/.storybook/config.ts
This file was deleted.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
42 changes: 42 additions & 0 deletionsweb-app/.storybook/main.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| const path = require('path') | ||
| const MiniCssExtractPlugin = require('mini-css-extract-plugin') | ||
| // import '../src/styles/reset.css' | ||
| module.exports = { | ||
| core: { | ||
| builder: 'webpack4', | ||
| }, | ||
| stories: ['../stories/Temp.stories.tsx', '../stories/Error.stories.tsx'], | ||
| addons: ['@storybook/addon-actions', '@storybook/addon-knobs', '@storybook/addon-links'], | ||
| babel: async (options) => ({ | ||
| ...options, | ||
| presets: [...options.presets, '@emotion/babel-preset-css-prop', '@babel/preset-react'], | ||
| plugins: [ | ||
| [ | ||
| 'import', | ||
| { | ||
| libraryName: '@alifd/next', | ||
| style: true, | ||
| }, | ||
| ], | ||
| ], | ||
| }), | ||
| webpackFinal: (config) => { | ||
| config.module.rules.push({ | ||
| test: /\.scss$/, | ||
| use: ['style-loader', 'css-loader', 'sass-loader'], | ||
| }) | ||
| config.module.rules.push({ | ||
| test: /\.(ts|tsx)$/, | ||
| loader: require.resolve('babel-loader'), | ||
| }) | ||
| config.plugins.push(new MiniCssExtractPlugin({ filename: '[name].css' })) | ||
| config.resolve.extensions.push('.ts', '.tsx') | ||
| config.resolve.modules = ['node_modules', path.resolve(__dirname, '../src')] | ||
| return config | ||
| }, | ||
| } |
7 changes: 7 additions & 0 deletionsweb-app/.storybook/preview.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| // setup acquireVsCodeApi mock | ||
| // @ts-ignore | ||
| global.acquireVsCodeApi = () => ({ | ||
| postMessage(event) { | ||
| console.log('ERROR: VSCode did not load properly in CodeRoad extension', event) | ||
| }, | ||
| }) |
25 changes: 7 additions & 18 deletionsweb-app/.storybook/webpack.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
19 changes: 12 additions & 7 deletionsweb-app/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
39 changes: 23 additions & 16 deletionsweb-app/stories/Error.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,27 @@ | ||
| import * as E from '../../typings/error' | ||
| import React from 'react' | ||
| import ErrorView from '../src/components/Error' | ||
| const Error = ({ send }) => { | ||
| const error: E.ErrorMessage = { | ||
| type: 'UnknownError', | ||
| message: '### Message summary\n\nSome message about what went wrong under here', | ||
| actions: [ | ||
| { label: 'First', transition: 'FIRST' }, | ||
| { label: 'Second', transition: 'SECOND' }, | ||
| ], | ||
| } | ||
| return <ErrorView error={error} send={send} /> | ||
| } | ||
| export default { | ||
| /* 👇 The title prop is optional. | ||
| * See https://storybook.js.org/docs/react/configure/overview#configure-story-loading | ||
| * to learn how to generate automatic titles | ||
| */ | ||
| title: 'Error', | ||
| component: ErrorView, | ||
| argTypes: { send: { action: 'send' } }, | ||
| } | ||
| export const Primary = () => <Error /> |
16 changes: 16 additions & 0 deletionsweb-app/stories/Temp.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // Button.stories.js|jsx | ||
| import React from 'react' | ||
| const Button = ({ primary, children }) => <button>{children}</button> | ||
| export default { | ||
| /* 👇 The title prop is optional. | ||
| * See https://storybook.js.org/docs/react/configure/overview#configure-story-loading | ||
| * to learn how to generate automatic titles | ||
| */ | ||
| title: 'Button', | ||
| component: Button, | ||
| } | ||
| export const Primary = () => <Button primary>Button</Button> |
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.