Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Refactor#422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ShMcK merged 2 commits intomasterfromrefactor
Aug 4, 2020
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletionsdocs/docs/config-yml.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,15 +38,15 @@ config:
tap:--reporter=mocha-tap-reporter
## The directory where to run the test runner from. If not specified, tests will run from the root of the project. Optional.
directory:coderoad
## Commits to load to setup the test runner. Optional.
setup:
## A list of commands to run to configure the tutorial
commands:
-npm install
## App versions helps to ensure compatability with the Extension
appVersions:
## Ensure compatability with a minimal VSCode CodeRoad version
vscode:'>=0.7.0'
## Setup commands
setup:
## A list of commands to run to configure the tutorial
commands:
-npm install
## Repo information to load code from
##
repo:
Expand Down
2 changes: 1 addition & 1 deletiondocs/docs/errors.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,4 +9,4 @@ Error loading commits:
Callback must be a function
```

If you get the above error when running`coderoad build`, check your node version with`node --version`. If it's less than version 12, try upgrading and run the command again.
If you get the above error when running`coderoad build`, check your node version with`node --version`. If it's less than version 12, try upgrading and run the command again.
4 changes: 2 additions & 2 deletionsdocs/docs/examples.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,5 +6,5 @@ sidebar_label: Examples

Check out some of these tutorial repositories for reference:

-https://github.com/coderoad/fcc-learn-npm
-https://github.com/coderoad/fcc-basic-node-and-express
-<https://github.com/coderoad/fcc-learn-npm>
-<https://github.com/coderoad/fcc-basic-node-and-express>
14 changes: 5 additions & 9 deletionsdocs/docs/yaml.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -70,15 +70,11 @@ config:
tap:--reporter=mocha-tap-reporter
## The directory where to run the test runner from. If not specified, tests will run from the root of the project. Optional.
directory:coderoad
## Commits to load to setup the test runner. Optional.
##
setup:
# - commit1
# - commit2
## A list of commands to run to configure the tutorial
commands:
[]
# - npm install
## Initial setup
##
setup:
## A list of commands to run to configure the tutorial
commands:[]
## App versions helps to ensure compatability with the Extension
appVersions:
## Ensure compatability with a minimal VSCode CodeRoad version
Expand Down
16 changes: 8 additions & 8 deletionspackage.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,14 +34,6 @@
"watch":"tsc -watch -p ./"
},
"dependencies": {
"@types/assert":"^1.5.1",
"@types/jest":"^26.0.8",
"@types/jsdom":"^16.2.3",
"@types/node":"^14.0.27",
"@types/node-fetch":"^2.5.7",
"@types/semver":"^7.3.1",
"@typescript-eslint/eslint-plugin":"^3.7.1",
"@typescript-eslint/parser":"^3.7.1",
"chokidar":"^3.4.1",
"dotenv":"^8.2.0",
"eslint":"^7.6.0",
Expand All@@ -55,6 +47,14 @@
"vscode-extension-telemetry":"^0.1.6"
},
"devDependencies": {
"@types/assert":"^1.5.1",
"@types/jest":"^26.0.8",
"@types/jsdom":"^16.2.3",
"@types/node":"^14.0.27",
"@types/node-fetch":"^2.5.7",
"@types/semver":"^7.3.1",
"@typescript-eslint/eslint-plugin":"^3.7.1",
"@typescript-eslint/parser":"^3.7.1",
"eslint-config-prettier":"^6.11.0",
"eslint-config-react-app":"^5.2.1",
"eslint-plugin-flowtype":"^5.2.0",
Expand Down
2 changes: 1 addition & 1 deletionsrc/actions/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,5 +4,5 @@ export { default as onTutorialConfigContinue } from './onTutorialConfigContinue'
export{defaultasonValidateSetup}from'./onValidateSetup'
export{defaultasonRunReset}from'./onRunReset'
export{defaultasonErrorPage}from'./onErrorPage'
export{onRunTest,onTestPass}from'./onTest'
export{runTest,onTestPass}from'./onTest'
export{onOpenLogs}from'./onOpenLogs'
2 changes: 1 addition & 1 deletionsrc/actions/onTest.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,6 +9,6 @@ export const onTestPass = (action: T.Action, context: Context): void => {
git.saveCommit('Save progress')
}

export constonRunTest = (action?: T.Action): void => {
export construnTest = (action?: T.Action): void => {
vscode.commands.executeCommand(COMMANDS.RUN_TEST, action?.payload)
}
2 changes: 1 addition & 1 deletionsrc/channel.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -73,7 +73,7 @@ class Channel implements Channel {
actions.onOpenLogs(action)
return
case 'EDITOR_RUN_TEST':
actions.onRunTest(action)
actions.runTest(action)
return
case 'EDITOR_RUN_RESET_LATEST':
actions.onRunReset({ type: 'LATEST' }, this.context)
Expand Down
4 changes: 2 additions & 2 deletionssrc/services/hooks/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ import openFiles from './utils/openFiles'
importrunCommandsfrom'./utils/runCommands'
importrunVSCodeCommandsfrom'./utils/runVSCodeCommands'
import{onErrorastelemetryOnError}from'../telemetry'
import{onRunTest}from'../../actions/onTest'
import{runTest}from'../../actions/onTest'
importloggerfrom'../logger'

exportconstonInit=async(actions:TT.StepActions):Promise<void>=>{
Expand DownExpand Up@@ -35,7 +35,7 @@ export const onSolutionEnter = async (actions: TT.StepActions): Promise<void> =>
awaitopenFiles(actions?.files)
awaitrunCommands(actions?.commands)
awaitrunVSCodeCommands(actions?.vscodeCommands)
awaitonRunTest()
awaitrunTest()
}

exportconstonReset=async(actions:TT.StepActions):Promise<void>=>{
Expand Down
2 changes: 1 addition & 1 deletionsrc/services/testRunner/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,7 +63,7 @@ const createTestRunner = (data: TT.Tutorial, callbacks: Callbacks): ((params: an
// get tutorial step from position
// check the step actions for specific command
// NOTE: cannot just pass in step actions as the test can be called by:
// - onEditorSave, onWatcher, onSolution,onRunTest, onSubTask
// - onEditorSave, onWatcher, onSolution,runTest, onSubTask
constlevels=data.levels
constlevel=levels.find((l)=>l.id===position.levelId)
conststep=level?.steps.find((s)=>s.id===position.stepId)
Expand Down
[8]ページ先頭
©2009-2025 Movatter.jp