Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix/linting#415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ShMcK merged 3 commits intomasterfromfix/linting
Aug 1, 2020
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions.github/workflows/test.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
name: CI
on: push
jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Install modules
run: yarn install
- name: Lint
run: yarn lint
build-extension:
runs-on: ubuntu-latest
steps:
Expand Down
19 changes: 12 additions & 7 deletionspackage.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,29 +35,34 @@
},
"dependencies": {
"@types/assert": "^1.5.1",
"@types/jest": "^26.0.5",
"@types/jest": "^26.0.8",
"@types/jsdom": "^16.2.3",
"@types/node": "^14.0.24",
"@types/node": "^14.0.27",
"@types/node-fetch": "^2.5.7",
"@types/semver": "^7.3.1",
"@typescript-eslint/eslint-plugin": "^3.7.0",
"@typescript-eslint/parser": "^3.7.0",
"@typescript-eslint/eslint-plugin": "^3.7.1",
"@typescript-eslint/parser": "^3.7.1",
"chokidar": "^3.4.1",
"dotenv": "^8.2.0",
"eslint": "^7.5.0",
"eslint": "^7.6.0",
"git-url-parse": "^11.1.2",
"jest": "^26.1.0",
"jest": "^26.2.2",
"jsdom": "^16.3.0",
"node-fetch": "^2.6.0",
"semver": "^7.3.2",
"ts-jest": "^26.1.3",
"ts-jest": "^26.1.4",
"typescript": "^3.9.7",
"vscode-extension-telemetry": "^0.1.6"
},
"devDependencies": {
"eslint-config-prettier": "^6.11.0",
"eslint-config-react-app": "^5.2.1",
"eslint-plugin-flowtype": "^5.2.0",
"eslint-plugin-import": "^2.22.0",
"eslint-plugin-jsx-a11y": "^6.3.1",
"eslint-plugin-prettier": "^3.1.4",
"eslint-plugin-react": "^7.20.5",
"eslint-plugin-react-hooks": "^4.0.8",
"prettier": "2.0.5",
"vscode": "^1.1.37",
"vscode-test": "^1.4.0"
Expand Down
2 changes: 1 addition & 1 deletionsrc/actions/onErrorPage.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import * as T from 'typings'
import { readFile } from '../services/node'
import logger from '../services/logger'

const onErrorPage = async (action: T.Action) => {
const onErrorPage = async (action: T.Action): void => {
// Error middleware
if (action?.payload?.error?.type) {
// load error markdown message
Expand Down
2 changes: 1 addition & 1 deletionsrc/actions/onOpenLogs.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as T from 'typings'
import { showOutput } from '../services/testRunner/output'

export const onOpenLogs = async (action: T.Action) => {
export const onOpenLogs = async (action: T.Action): void => {
const channel = action.payload.channel
await showOutput(channel)
}
Expand Down
2 changes: 1 addition & 1 deletionsrc/actions/onRunReset.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@ type ResetAction = {
}

// reset to the start of the last test
const onRunReset = async (action: ResetAction, context: Context) => {
const onRunReset = async (action: ResetAction, context: Context): void => {
// reset to timeline
const tutorial: TT.Tutorial | null = context.tutorial.get()
const position: T.Position = action.position ? action.position : context.position.get()
Expand Down
2 changes: 1 addition & 1 deletionsrc/actions/onStartup.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@ const onStartup = async (
context: Context,
workspaceState: vscode.Memento,
send: (action: T.Action) => Promise<void>,
) => {
): void => {
try {
// check if a workspace is open, otherwise nothing works
const noActiveWorkspace = !WORKSPACE_ROOT.length
Expand Down
4 changes: 2 additions & 2 deletionssrc/actions/onTest.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,11 +4,11 @@ import * as vscode from 'vscode'
import { COMMANDS } from '../commands'
import Context from '../services/context/context'

export const onTestPass = (action: T.Action, context: Context) => {
export const onTestPass = (action: T.Action, context: Context): void => {
context.position.set({ ...action.payload.position, complete: true })
git.saveCommit('Save progress')
}

export const onRunTest = (action?: T.Action) => {
export const onRunTest = (action?: T.Action): void => {
vscode.commands.executeCommand(COMMANDS.RUN_TEST, action?.payload)
}
2 changes: 1 addition & 1 deletionsrc/actions/onTutorialConfigContinue.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@ import Context from '../services/context/context'
import tutorialConfig from './utils/tutorialConfig'
import { COMMANDS } from '../commands'

const onTutorialConfigContinue = async (action: T.Action, context: Context, send:any) => {
const onTutorialConfigContinue = async (action: T.Action, context: Context, send:T.Send): void => {
try {
const tutorialContinue: TT.Tutorial | null = context.tutorial.get()
if (!tutorialContinue) {
Expand Down
4 changes: 2 additions & 2 deletionssrc/actions/onTutorialConfigNew.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ import { version, compareVersions } from '../services/dependencies'
import Context from '../services/context/context'
import tutorialConfig from './utils/tutorialConfig'

const onTutorialConfigNew = async (action: T.Action, context: Context, send:any) => {
const onTutorialConfigNew = async (action: T.Action, context: Context, send:T.Send): void => {
try {
const data: TT.Tutorial = action.payload.tutorial

Expand DownExpand Up@@ -82,7 +82,7 @@ const onTutorialConfigNew = async (action: T.Action, context: Context, send: any
if (satisfiedDependency !== true) {
const error: E.ErrorMessage = satisfiedDependency || {
type: 'UnknownError',
message: `Something went wrong comparing dependency for ${name}`,
message: `Something went wrong comparing dependency for ${dep.name}`,
actions: [
{
label: 'Try Again',
Expand Down
2 changes: 1 addition & 1 deletionsrc/actions/onValidateSetup.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import * as E from 'typings/error'
import { version } from '../services/dependencies'
import { checkWorkspaceEmpty } from '../services/workspace'

const onValidateSetup = async (send:any) => {
const onValidateSetup = async (send:T.Send): void => {
try {
// check workspace is selected
const isEmptyWorkspace = await checkWorkspaceEmpty()
Expand Down
2 changes: 2 additions & 0 deletionstypings/index.d.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,6 +54,8 @@ export interface Action {
meta?: any
}

export type Send = (action: Action) => void

export interface Environment {
machineId: string
sessionId: string
Expand Down
12 changes: 6 additions & 6 deletionsweb-app/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,10 +25,10 @@
"extends": "react-app"
},
"dependencies": {
"@alifd/next": "^1.20.20",
"@alifd/next": "^1.20.24",
"@emotion/babel-preset-css-prop": "^10.0.27",
"@emotion/core": "^10.0.28",
"babel-jest": "^26.1.0",
"babel-jest": "^26.2.2",
"js-yaml": "^3.14.0",
"markdown-it": "^11.0.0",
"markdown-it-emoji": "^1.4.0",
Expand All@@ -42,7 +42,7 @@
"xstate": "^4.11.0"
},
"devDependencies": {
"@babel/core": "^7.10.5",
"@babel/core": "^7.11.0",
"@storybook/addon-actions": "^5.3.19",
"@storybook/addon-knobs": "^5.3.19",
"@storybook/addon-links": "^5.3.19",
Expand All@@ -51,12 +51,12 @@
"@storybook/react": "^5.3.19",
"@types/graphql": "^14.5.0",
"@types/highlight.js": "^9.12.4",
"@types/jest": "^26.0.5",
"@types/jest": "^26.0.8",
"@types/js-yaml": "^3.12.5",
"@types/markdown-it": "^10.0.1",
"@types/node": "^14.0.24",
"@types/node": "^14.0.27",
"@types/prismjs": "^1.16.1",
"@types/react": "^16.9.43",
"@types/react": "^16.9.44",
"@types/react-addons-css-transition-group": "^15.0.5",
"@types/react-dom": "^16.9.8",
"babel-loader": "8.1.0",
Expand Down
Loading
[8]ページ先頭
©2009-2025 Movatter.jp