Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

allow for separate coderoad directory#276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ShMcK merged 4 commits intomasterfromfeature/coderoad-directory
Apr 18, 2020

Conversation

ShMcK
Copy link
Member

@ShMcKShMcK commentedApr 17, 2020•
edited
Loading

closes#273.
closes#187.

Allows for CodeRoad test runner to be built in a separate directory.

  • This is a breaking change, so should require first validating the version of CodeRoad schema with the version of the extension first.

Signed-off-by: shmckshawn.j.mckay@gmail.com

@ShMcKShMcK added this to theStable Release milestoneApr 17, 2020
@ShMcKShMcKforce-pushed thefeature/coderoad-directory branch from26bdfcc toa335f07CompareApril 17, 2020 01:00
Signed-off-by: shmck <shawn.j.mckay@gmail.com>
Signed-off-by: shmck <shawn.j.mckay@gmail.com>
@ShMcKShMcKforce-pushed thefeature/coderoad-directory branch froma335f07 toeaf27ffCompareApril 17, 2020 03:34
Signed-off-by: shmck <shawn.j.mckay@gmail.com>
@ShMcK
Copy link
MemberAuthor

ShMcK commentedApr 17, 2020•
edited
Loading

One remaining issue.

  • The setup commands in the coderoad directory don't seem to work correctly.
    Eg.npm install generates acoderoad/package-lock.json, but nocoderoad/node_modules.

If I run the same commands manually, they work. Really not sure why.

@ShMcK
Copy link
MemberAuthor

Resovled - issue was related to my local NODE_ENV=production, and the test dependencies living indevDependencies that don't get called in npm install when production.

Signed-off-by: shmck <shawn.j.mckay@gmail.com>
@ShMcKShMcK merged commitd875e4c intomasterApr 18, 2020
@ShMcKShMcK deleted the feature/coderoad-directory branchApril 18, 2020 00:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Stable Release
Development

Successfully merging this pull request may close these issues.

Run coderoad from separate folder Ensure test runner is installed before commands run
1 participant
@ShMcK
[8]ページ先頭
©2009-2025 Movatter.jp