- Notifications
You must be signed in to change notification settings - Fork39
Windows run#259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Windows run#259
Changes from8 commits
Commits
Show all changes
10 commits Select commitHold shift + click to select a range
6bafe24
WIP: fix extension to run on windows computers
argemiront2c497e7
parse version on windows
ShMcKc63ef14
update package versions
argemirontb1d32cd
Add readonly - fix eslint
argemiront7c278f7
change the import for Windows
argemiront454ea9d
Add darwin as possible OS to ts
argemirontf29d40d
Temp fix for WORKSPACE_ROOT on Windows
argemiront53dde7a
fix the Workspace path issue
argemiront9f4f66e
Merge branch 'master' into windows-run
argemiront9ec63c8
prepare 0.2.3 release with notes
ShMcKFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletionpackage.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -58,7 +58,7 @@ | ||
"vscode-test":"^1.3.0" | ||
}, | ||
"engines": { | ||
"vscode":"^1.44.0" | ||
}, | ||
"activationEvents": [ | ||
"onCommand:coderoad.start" | ||
4 changes: 3 additions & 1 deletionscripts/build.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -14,7 +14,9 @@ tsc -p ./ | ||
cd web-app | ||
npm run build | ||
cd .. | ||
# For Windows build: switch the next 2 lines | ||
# cp -R ./web-app/build/ ./ | ||
cp -R ./web-app/build/ ./build | ||
Comment on lines +18 to +19 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Could we wrap these in a os platform conditional in bash? | ||
node scripts/fixFontPaths.js | ||
echo "Build complete!" |
2 changes: 1 addition & 1 deletionsrc/actions/utils/openFiles.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletionsrc/environment.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
5 changes: 3 additions & 2 deletionssrc/services/dependencies/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
9 changes: 5 additions & 4 deletionssrc/services/workspace/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
17 changes: 6 additions & 11 deletionssrc/webview/render.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.