- Notifications
You must be signed in to change notification settings - Fork39
Windows run#259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Windows run#259
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: argemiront <argemiront@gmail.com>
Signed-off-by: shmck <shawn.j.mckay@gmail.com>
Signed-off-by: argemiront <argemiront@gmail.com>
Signed-off-by: argemiront <argemiront@gmail.com>
Signed-off-by: argemiront <argemiront@gmail.com>
Signed-off-by: argemiront <argemiront@gmail.com>
Signed-off-by: argemiront <argemiront@gmail.com>
Signed-off-by: argemiront <argemiront@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks great! Tested, and does not break anything on Mac.
We should also update the README where it states "Mac only"
| # cp -R ./web-app/build/ ./ | ||
| cp -R ./web-app/build/ ./build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could we wrap these in a os platform conditional in bash?
closes#122 |
Signed-off-by: argemiront <argemiront@gmail.com>
Signed-off-by: shmck <shawn.j.mckay@gmail.com>
Add compatibility on Windows machines