Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit78c2c1d

Browse files
committed
limit hook payloads
Signed-off-by: shmck <shawn.j.mckay@gmail.com>
1 parentcf4095f commit78c2c1d

File tree

3 files changed

+13
-14
lines changed

3 files changed

+13
-14
lines changed

‎src/services/hooks/index.ts

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import runCommands from './utils/runCommands'
88
importrunVSCodeCommandsfrom'./utils/runVSCodeCommands'
99
import{onErrorastelemetryOnError}from'../telemetry'
1010
import{onRunTest}from'../../actions/onTest'
11+
importloggerfrom'../logger'
1112

1213
exportconstonInit=async(actions:TT.StepActions):Promise<void>=>{
1314
awaitloadCommits(actions?.commits)
@@ -41,17 +42,14 @@ export const onError = async (error: Error): Promise<void> => {
4142
telemetryOnError(error)
4243
}
4344

44-
exportconstonStepComplete=async({ position}:{position:T.Position}):Promise<void>=>{
45-
/* TODO */
46-
console.log(`ON STEP COMPLETE:${JSON.stringify(position)}`)
45+
exportconstonStepComplete=async({ levelId, stepId}:{levelId:string;stepId:string}):Promise<void>=>{
46+
logger(`ON STEP COMPLETE:${JSON.stringify({ levelId, stepId})}`)
4747
}
4848

49-
exportconstonLevelComplete=async({ position}:{position:T.Position}):Promise<void>=>{
50-
/* TODO */
51-
console.log(`ON LEVEL COMPLETE:${JSON.stringify(position)}`)
49+
exportconstonLevelComplete=async({ levelId}:{levelId:string}):Promise<void>=>{
50+
logger(`ON LEVEL COMPLETE:${JSON.stringify(levelId)}`)
5251
}
5352

54-
exportconstonTutorialComplete=async({ position}:{position:T.Position}):Promise<void>=>{
55-
/* TODO */
56-
console.log(`ON LEVEL COMPLETE:${JSON.stringify(position)}`)
53+
exportconstonTutorialComplete=async({ tutorialId}:{tutorialId:string}):Promise<void>=>{
54+
logger(`ON TUTORIAL COMPLETE:${JSON.stringify(tutorialId)}`)
5755
}

‎web-app/src/services/state/actions/editor.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,23 +137,24 @@ export default (editorSend: any) => ({
137137
editorSend({
138138
type:'EDITOR_STEP_COMPLETE',
139139
payload:{
140-
position:context.position,
140+
levelId:context.position.levelId,
141+
stepId:context.position.levelId,
141142
},
142143
})
143144
},
144145
onLevelComplete(context:T.MachineContext):void{
145146
editorSend({
146147
type:'EDITOR_LEVEL_COMPLETE',
147148
payload:{
148-
position:context.position,
149+
levelId:context.position.levelId,
149150
},
150151
})
151152
},
152153
onTutorialComplete(context:T.MachineContext):void{
153154
editorSend({
154155
type:'EDITOR_TUTORIAL_COMPLETE',
155156
payload:{
156-
position:context.position,
157+
tutorialId:context.tutorial?.id,
157158
},
158159
})
159160
},

‎web-app/src/services/state/machine.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ export const createMachine = (options: any) => {
181181
on:{
182182
TEST_PASS:{
183183
target:'StepNext',
184-
actions:['testPass','updateStepPosition'],
184+
actions:['onStepComplete','testPass','updateStepPosition'],
185185
},
186186
TEST_FAIL:{
187187
target:'Normal',
@@ -198,7 +198,7 @@ export const createMachine = (options: any) => {
198198
on:{
199199
LOAD_NEXT_STEP:{
200200
target:'Normal',
201-
actions:['onStepComplete','loadStep','updateStepPosition'],
201+
actions:['loadStep','updateStepPosition'],
202202
},
203203
LEVEL_COMPLETE:{
204204
target:'LevelComplete',

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp