Commit382a6f8

committed

improve error handling with title/description

1 parentfb2ae61 commit382a6f8Copy full SHA for 382a6f8

File tree

+12

-3

lines changed

typings
- index.d.ts
web-app/src
- containers
  - LoadingPage.tsx
- services/state/actions
  - api.ts

+12

-3

lines changed

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -38,9 +38,14 @@ export interface Environment {`
`38`	`38`	`token:string`
`39`	`39`	`}`
`40`	`40`
	`41`	`+exportinterfaceErrorMessage{`
	`42`	`+title:string`
	`43`	`+description?:string`
	`44`	`+}`
	`45`	`+`
`41`	`46`	`exportinterfaceMachineContext{`
`42`	`47`	`env:Environment`
`43`		`-error:string\|null`
	`48`	`+error:ErrorMessage\|null`
`44`	`49`	`tutorial:G.Tutorial\|null`
`45`	`50`	`position:Position`
`46`	`51`	`progress:Progress`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ const LoadingPage = ({ text, context }: Props) => {`
`24`	`24`	`if(error){`
`25`	`25`	`return(`
`26`	`26`	`<divstyle={styles.page}>`
`27`		`-<Messagetype="error"title={error}/>`
	`27`	`+<Messagetype="error"title={error.title}description={error.description}/>`
`28`	`28`	`</div>`
`29`	`29`	`)`
`30`	`30`	`}`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,11 @@ export default {`
`34`	`34`	`if(!result\|\|!result.data){`
`35`	`35`	`// TODO: handle failed authentication`
`36`	`36`	`console.error('ERROR: Authentication failed')`
`37`		`-channel.receive({data:{type:'ERROR',payload:{error:'Authentication Failed'}}})`
	`37`	`+consterror={`
	`38`	`+title:'Authentication Failed',`
	`39`	`+description:'You may not be connected to the internet. Connect and restart the application',`
	`40`	`+}`
	`41`	`+channel.receive({data:{type:'ERROR',payload:{ error}}})`
`38`	`42`	`return`
`39`	`43`	`}`
`40`	`44`	`const{ token}=result.data.editorLogin`

Comments

(0)