Commit6627395

committed

require an "id" for a tutorial

Signed-off-by: shmck <shawn.j.mckay@gmail.com>

1 parent336e9fe commit6627395Copy full SHA for 6627395

File tree

+22

-1

lines changed

+22

-1

lines changed

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,12 @@ export default {`
`7`	`7`	`...meta,`
`8`	`8`	`type:"object",`
`9`	`9`	`properties:{`
	`10`	`+id:{`
	`11`	`+type:"string",`
	`12`	`+description:"A unique identifier for your tutorial. Currently no system to create this, so create your own for now",`
	`13`	`+examples:["fcc-learn-npm"]`
	`14`	`+},`
	`15`	`+`
`10`	`16`	`version:{`
`11`	`17`	`$ref:"#/definitions/semantic_version",`
`12`	`18`	`description:"The tutorial version. Must be unique for the tutorial.",`
`@@ -253,5 +259,5 @@ export default {`
`253`	`259`	`},`
`254`	`260`	`},`
`255`	`261`	`additionalProperties:false,`
`256`		`-required:["version","config","levels"],`
	`262`	`+required:["id","version","config","levels"],`
`257`	`263`	`};`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,12 @@ export default {`
`7`	`7`	`...meta,`
`8`	`8`	`type:"object",`
`9`	`9`	`properties:{`
	`10`	`+id:{`
	`11`	`+type:"string",`
	`12`	`+description:"A unique identifier for your tutorial. Currently no system to create this, so create your own for now",`
	`13`	`+examples:["fcc-learn-npm"]`
	`14`	`+},`
	`15`	`+`
`10`	`16`	`version:{`
`11`	`17`	`$ref:"#/definitions/semantic_version",`
`12`	`18`	`description:"The tutorial version. Must be unique for the tutorial.",`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ import skeletonSchema from '../src/schema/skeleton'`
`4`	`4`	`constvalidateSkeleton=(json:any)=>validateSchema(skeletonSchema,json)`
`5`	`5`
`6`	`6`	`constvalidJson={`
	`7`	`+id:'coderoad-test',`
`7`	`8`	`version:'0.1.0',`
`8`	`9`	`config:{`
`9`	`10`	`testRunner:{`
`@@ -95,6 +96,13 @@ describe('validate skeleton', () => {`
`95`	`96`	`constvalid=validateSkeleton(json)`
`96`	`97`	`expect(valid).toBe(true)`
`97`	`98`	`})`
	`99`	`+it('should fail if id is missing',()=>{`
	`100`	`+constjson={ ...validJson,id:undefined}`
	`101`	`+`
	`102`	`+constvalid=validateSkeleton(json)`
	`103`	`+expect(valid).toBe(false)`
	`104`	`+})`
	`105`	`+`
`98`	`106`	`it('should fail if version is invalid',()=>{`
`99`	`107`	`constjson={ ...validJson,version:'NOT A VERSION'}`
`100`	`108`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@ import tutorialSchema from '../src/schema/tutorial'`
`3`	`3`	`import{validateSchema}from'../src/utils/validateSchema'`
`4`	`4`
`5`	`5`	`constvalidJson:Partial<T.Tutorial>={`
	`6`	`+id:'coderoad-test',`
`6`	`7`	`version:'0.1.0',`
`7`	`8`	`summary:{title:'Title',description:'Description'},`
`8`	`9`	`config:{`

Comments

(0)